Localize FXIOS-9612 #21206 [FirefoxHomepage][shortcut] Localized Pinned Tiles for voice over accessibility (#25267)

Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>

Author: aarifsumra

firefox-ios/Client/Frontend/Home/Homepage Rebuild/TopSites/TopSiteConfiguration.swift

@@ -14,8 +14,19 @@ struct TopSiteConfiguration: Hashable, Equatable {
         return .FirefoxHomepage.Shortcuts.Sponsored
     }
 
+    private var pinnedTitle: String {
+        .localizedStringWithFormat(
+            .FirefoxHomepage.Shortcuts.PinnedAccessibilityLabel,
+            title
+        )
+    }
+
+    private var pinnedStatusTitle: String {
+        return isPinned ? pinnedTitle : title
+    }
+
     var accessibilityLabel: String? {
-        return isSponsored ? "\(title), \(sponsoredText)" : title
+        return isSponsored ? "\(pinnedStatusTitle), \(sponsoredText)" : pinnedStatusTitle
     }
 
     var isPinned: Bool {

firefox-ios/Client/Frontend/Home/TopSites/TopSite.swift

@@ -14,8 +14,19 @@ final class TopSite: FeatureFlaggable {
         return .FirefoxHomepage.Shortcuts.Sponsored
     }
 
+    private var pinnedTitle: String {
+        .localizedStringWithFormat(
+            .FirefoxHomepage.Shortcuts.PinnedAccessibilityLabel,
+            title
+        )
+    }
+
+    private var pinnedStatusTitle: String {
+        isPinned ? pinnedTitle : title
+    }
+
     var accessibilityLabel: String? {
-        return isSponsored ? "\(title), \(sponsoredText)" : title
+        return isSponsored ? "\(pinnedStatusTitle), \(sponsoredText)" : pinnedStatusTitle
     }
 
     var isPinned: Bool {

firefox-ios/Shared/Strings.swift

@@ -1172,6 +1172,13 @@ extension String {
                 tableName: nil,
                 value: "Sponsored",
                 comment: "This string will show under a shortcuts tile on the firefox home page, indicating that the tile is a sponsored tile. Space is limited, please keep as short as possible.")
+
+            public static let PinnedAccessibilityLabel = MZLocalizedString(
+                key: "FirefoxHomepage.Shortcuts.Pinned.AccessibilityLabel.v139",
+                tableName: "FirefoxHomepage",
+                value: "Pinned: %@",
+                comment: "Accessibility label for shortcuts tile on the Firefox home page, indicating that the tile is a pinned tile. %@ is the title of the website."
+            )
         }
 
         public struct YourLibrary { }

firefox-ios/firefox-ios-tests/Tests/XCUITests/BrowsingPDFTests.swift

@@ -109,7 +109,7 @@ class BrowsingPDFTests: BaseTestCase {
         // Open pdf from pinned site
         let pdfTopSite = app
             .collectionViews[AccessibilityIdentifiers.FirefoxHomepage.collectionView]
-            .links[PDF_website["bookmarkLabel"]!]
+            .links["Pinned: \(PDF_website["bookmarkLabel"]!)"]
             .children(matching: .other)
             .element
             .children(matching: .other)

firefox-ios/firefox-ios-tests/Tests/XCUITests/PhotonActionSheetTests.swift

@@ -23,10 +23,10 @@ class PhotonActionSheetTests: BaseTestCase {
         let cell = itemCell.staticTexts["Example Domain"]
         mozWaitForElementToExist(cell)
         if #available(iOS 17, *) {
-            mozWaitForElementToExist(app.links["Example Domain"].images[StandardImageIdentifiers.Small.pinBadgeFill])
+            mozWaitForElementToExist(app.links["Pinned: Example Domain"].images[StandardImageIdentifiers.Small.pinBadgeFill])
         } else {
             // No identifier is available for iOS 17 amd below
-            mozWaitForElementToExist(app.links["Example Domain"].images.element(boundBy: 1))
+            mozWaitForElementToExist(app.links["Pinned: Example Domain"].images.element(boundBy: 1))
         }
 
         // Remove pin