FileStorage: Create subdirs when using the method derive #33
Conversation
radoslavius
changed the title
| @@ -143,7 +143,7 @@ public function lock($key) | |||
| { | |||
| $cacheFile = $this->getCacheFile($key); | |||
| if ($this->useDirs && !is_dir($dir = dirname($cacheFile))) { | |||
| @mkdir($dir); // @ - directory may already exist | |||
| @mkdir($dir, 0777, true); // @ - directory may already exist | |||
There was a problem hiding this comment.
What about this solution? - http://stackoverflow.com/questions/15356189/creating-a-directory-from-multiple-threads/21626808#21626808
There was a problem hiding this comment.
@dg Let's say only a dir/ exists and 1st thread is creating dir/aaa/bbb/ and 2nd dir/aaa/ccc/. When they start in the same time, 1st creates dir/aaa/ and 2nd tries too. 1st is success and continues to create dir/aaa/bbb/ but 2nd fails and ends, so dir/aaa/ccc/ does not exist.
There was a problem hiding this comment.
@milo thanx!
Btw, FileStorage is using only one level of directories, isn't it? So this PR is not needed.
There was a problem hiding this comment.
@dg Imho, purpose is that $cache->derive('a')->derive('b')->derive('c')->save('key', 'val'); will create tmp/_a/_b/_c, now it creates tmp/_%00a%00b%00c.
dg
force-pushed
the
master
branch
3 times, most recently
from
2f8f6fb to
8c9cca3
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
0aed862 to
a0c400e
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
54c618b to
62a27d9
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
ec9e432 to
e07955b
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
492413c to
b0b475e
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
6037e83 to
1fe69cc
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
6df4f89 to
30051c1
Compare
dg
force-pushed
the
master
branch
10 times, most recently
from
265fdf3 to
2240ed0
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
2f60360 to
93f335f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
41b5503 to
327c2bf
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
3982670 to
d89af84
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
40be743 to
a116cb9
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
ea335de to
ccec70b
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
3ce492d to
fb5c89d
Compare
I do not know if it was the intention, but this behavior seems to me better. Especially if there is a large number of cached files.