Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing keepalived dependency for offline installation(NIM) #233

Merged
merged 10 commits into from
Feb 27, 2025

Conversation

bejjrajesh
Copy link
Contributor

Proposed changes

Problem: NIM 2.19.0 introduced a dependency on keepalived. For online installations, this dependency is getting auto resolved and installed. But offline installations are not packaging keepalived and it's dependencies in the final tar.gz archive file.

Solution: This MR contains the changes to include keepalived and it's dependencies in the zip archive created in the offline mode installation.

Testing: Manual testing performed on ubuntu and rpm based systems.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@bejjrajesh bejjrajesh requested a review from a team as a code owner February 27, 2025 08:44
@bejjrajesh bejjrajesh changed the title Rbejjanki/fixing keepalived dependency fixing keepalived dependency for offline installation(NIM) Feb 27, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to push minor text changes to the messages shown to users, and will then merge.

@mjang mjang enabled auto-merge (squash) February 27, 2025 14:53
@mjang mjang merged commit 38474a1 into nginx:main Feb 27, 2025
2 checks passed
@mjang
Copy link
Contributor

mjang commented Feb 27, 2025

@bejjrajesh One comment -- I see you used "please" when telling the user to install Docker. In most cases, we wouldn't use "please," as it's sort of a waste of space.

But in this particular case, it's appropriate. Nice work! Per Google guidelines (material.io is essentially a Google style guide),

However, "please" may be used when asking the user to do something inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants