-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing keepalived dependency for offline installation(NIM) #233
fixing keepalived dependency for offline installation(NIM) #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to push minor text changes to the messages shown to users, and will then merge.
@bejjrajesh One comment -- I see you used "please" when telling the user to install Docker. In most cases, we wouldn't use "please," as it's sort of a waste of space. But in this particular case, it's appropriate. Nice work! Per Google guidelines (material.io is essentially a Google style guide),
|
Proposed changes
Problem: NIM 2.19.0 introduced a dependency on keepalived. For online installations, this dependency is getting auto resolved and installed. But offline installations are not packaging keepalived and it's dependencies in the final tar.gz archive file.
Solution: This MR contains the changes to include keepalived and it's dependencies in the zip archive created in the offline mode installation.
Testing: Manual testing performed on ubuntu and rpm based systems.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩