Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to point towards Standard V2 #254

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

puneetsarna
Copy link
Contributor

@puneetsarna puneetsarna commented Mar 4, 2025

Now that we have the Standard plan officially
retired, we should update our docs with the same
information and point users to migrate over to it.

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@puneetsarna puneetsarna requested a review from a team as a code owner March 4, 2025 17:46
Copy link

@russokj russokj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise looks good.

Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues from a documentation point of view but the comments about the Standard V2 wording should be addressed

Now that we have the Standard plan officially
retired, we should update our docs with the same
information and point users to migrate over to it.
@JTorreG JTorreG added the product/nginxaas NGINX as a Service for Azure label Mar 5, 2025
@russokj
Copy link

russokj commented Mar 6, 2025

@JTorreG / @jputrino - This MR is requiring two approvals, but I cannot approve it. Does it require two approvals from the doc team? If so, we need to make that just one approval. Ideally, it should require 1 from the dev team and 1 from the docs team (but with how the repo is organized we may not be able to fine tune which dev team).

In any case, can we get the second approval for this?

@JTorreG
Copy link
Contributor

JTorreG commented Mar 11, 2025

@JTorreG / @jputrino - This MR is requiring two approvals, but I cannot approve it. Does it require two approvals from the doc team? If so, we need to make that just one approval. Ideally, it should require 1 from the dev team and 1 from the docs team (but with how the repo is organized we may not be able to fine tune which dev team).

In any case, can we get the second approval for this?

Docs changes require 2 DocOps approvals. This is intended.

@JTorreG JTorreG merged commit 3392ec0 into nginx:main Mar 11, 2025
5 checks passed
eepifanova added a commit that referenced this pull request Mar 28, 2025
Update docs to point towards Standard V2 (#254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/nginxaas NGINX as a Service for Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants