Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nap helm chart #267

Merged
merged 6 commits into from
Mar 13, 2025
Merged

Conversation

liadlevif5
Copy link
Contributor

@liadlevif5 liadlevif5 commented Mar 11, 2025

Proposed changes

Add support for installing NAP 5 with Helm Chart

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@liadlevif5 liadlevif5 requested review from a team as code owners March 11, 2025 12:51
@liadlevif5 liadlevif5 changed the base branch from nap-release-5.6 to main March 11, 2025 12:52
@JTorreG JTorreG requested a review from ADubhlaoich March 11, 2025 12:55
…h-helm.md

Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
@JTorreG JTorreG added the product/nap-waf NGINX App Protect WAF label Mar 11, 2025
liadlevif5 and others added 2 commits March 11, 2025 15:59
…h-helm.md

Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 12, 2025
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohad-perets
Copy link
Contributor

I think that it's better to merge it tothe release branch and not to the main(and once official, we will move it to the main)

@ADubhlaoich ADubhlaoich changed the base branch from main to nap-release-5.6 March 12, 2025 15:27
@ADubhlaoich
Copy link
Contributor

I've changed the target branch for this PR to nap-release-5.6 per Ohad's recommendation.

Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
@ADubhlaoich ADubhlaoich merged commit 676aab0 into nginx:nap-release-5.6 Mar 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nap-waf NGINX App Protect WAF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants