generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nap helm chart #267
Merged
Merged
Nap helm chart #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JTorreG
reviewed
Mar 11, 2025
content/nap-waf/v5/admin-guide/deploy-on-kubernetes/deploy-with-helm.md
Outdated
Show resolved
Hide resolved
…h-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
JTorreG
reviewed
Mar 11, 2025
content/nap-waf/v5/admin-guide/deploy-on-kubernetes/deploy-with-helm.md
Outdated
Show resolved
Hide resolved
…h-helm.md Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
ADubhlaoich
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think that it's better to merge it tothe release branch and not to the main(and once official, we will move it to the main) |
I've changed the target branch for this PR to |
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for installing NAP 5 with Helm Chart
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩