Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure zone_sync takes priority over scale setting for RateLimit policy #7398

Open
1 of 3 tasks
shaun-nx opened this issue Feb 24, 2025 · 1 comment · May be fixed by #7521
Open
1 of 3 tasks

Ensure zone_sync takes priority over scale setting for RateLimit policy #7398

shaun-nx opened this issue Feb 24, 2025 · 1 comment · May be fixed by #7521
Assignees
@AlexFenlon @pdabelf5
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Milestone
v4.1.0

Comments

@shaun-nx
Copy link
Contributor

shaun-nx commented Feb 24, 2025 •
edited by pdabelf5
Loading

Overview

When a RateLimit policy is deployed with the scale setting enabled, and zone_sync is also enabled, I want to ensure that zone_sync takes priority and that the policy resource displays a correct warning message to the user

Acceptance Criteria

  • Ensure scale settings for a RateLimit policy are ignored when zone_sync is enabled
  • Ensure that a Warning message is emitted as an event to the RateLimit policy to inform the user that the scale setting is ignored.
  • Ensure the RateLimit policy still operates normally after this warning is emitted
@shaun-nx shaun-nx added the proposal An issue that proposes a feature request label Feb 24, 2025
@github-actions GitHub Actions
Copy link

Hi @shaun-nx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@shaun-nx shaun-nx added the ready for refinement An issue that was triaged and it is ready to be refined label Feb 24, 2025
@shaun-nx shaun-nx moved this from Todo ☑ to Prioritized backlog in NGINX Ingress Controller Feb 28, 2025
@shaun-nx shaun-nx modified the milestone: v4.1.0 Feb 28, 2025
@vepatel vepatel added backlog Pull requests/issues that are backlog items and removed ready for refinement An issue that was triaged and it is ready to be refined labels Mar 4, 2025
@vepatel vepatel added this to the v4.1.0 milestone Mar 4, 2025
@AlexFenlon AlexFenlon moved this from Prioritized backlog to Todo ☑ in NGINX Ingress Controller Mar 5, 2025
@danielnginx danielnginx moved this from Todo ☑ to In Progress 🛠 in NGINX Ingress Controller Mar 6, 2025
@AlexFenlon AlexFenlon linked a pull request Mar 6, 2025 that will close this issue
add rate limit zone sync docs #7481
Open
6 tasks
@AlexFenlon AlexFenlon removed a link to a pull request Mar 6, 2025
add rate limit zone sync docs #7481
Open
6 tasks
@AlexFenlon AlexFenlon linked a pull request Mar 6, 2025 that will close this issue
Rate limit with zone sync and scale #7473
Closed
6 tasks
@pdabelf5 pdabelf5 linked a pull request Mar 17, 2025 that will close this issue
Rate limit with zone sync and scale #7521
Open
6 tasks
@pdabelf5 pdabelf5 moved this from In Progress 🛠 to In Review 👀 in NGINX Ingress Controller Mar 17, 2025
@AlexFenlon AlexFenlon removed a link to a pull request Mar 19, 2025
Rate limit with zone sync and scale #7473
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexFenlon AlexFenlon

@pdabelf5 pdabelf5

Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Projects
NGINX Ingress Controller
Status: In Review 👀
Milestone
v4.1.0
Development

Successfully merging a pull request may close this issue.

Rate limit with zone sync and scale nginx/kubernetes-ingress
4 participants
@vepatel @AlexFenlon @shaun-nx @pdabelf5