-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP Split: Update functional tests #3207
Merged
bjee19
merged 8 commits into
change/control-data-plane-split
from
tests/update-tests-for-cp-dp
Mar 23, 2025
Merged
CP/DP Split: Update functional tests #3207
bjee19
merged 8 commits into
change/control-data-plane-split
from
tests/update-tests-for-cp-dp
Mar 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functional tests pass locally, opening PR to run them in the pipeline |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3207 +/- ##
===================================================================
- Coverage 89.74% 86.96% -2.79%
===================================================================
Files 109 121 +12
Lines 11150 13739 +2589
Branches 50 62 +12
===================================================================
+ Hits 10007 11948 +1941
- Misses 1083 1672 +589
- Partials 60 119 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjberman
reviewed
Mar 12, 2025
efa75dd
to
16c230d
Compare
16c230d
to
95379ec
Compare
sjberman
reviewed
Mar 19, 2025
sjberman
approved these changes
Mar 20, 2025
salonichf5
approved these changes
Mar 21, 2025
a9f53ec
into
change/control-data-plane-split
29 of 37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update functional tests for the control plane data plane split.
Problem: The functional tests do not pass with the current architecture.
Solution: Add updates to functional tests, notable changes made:
Bugs fixed:
Fixed by tracking gateway delete event when NGF is not leader.
Opened bug: #3248
Closes part of #3010
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.