Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/onsi/ginkgo/v2 to v2.23.3 - autoclosed #3256

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 22, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/onsi/ginkgo/v2 v2.23.0 -> v2.23.3 age adoption passing confidence

Release Notes

onsi/ginkgo (github.com/onsi/ginkgo/v2)

v2.23.3

Compare Source

2.23.3

Fixes
  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

v2.23.2

Compare Source

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

Compare Source

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.


Configuration

📅 Schedule: Branch creation - "* 0-3 * * *" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 22, 2025
@renovate renovate bot requested a review from a team as a code owner March 22, 2025 10:31
@renovate renovate bot enabled auto-merge (squash) March 22, 2025 10:31
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (92beadc) to head (8ddddd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3256   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files         113      113           
  Lines       11658    11658           
  Branches       62       62           
=======================================
  Hits        10044    10044           
  Misses       1553     1553           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot force-pushed the renovate/github.com-onsi-ginkgo-v2-2.x branch 4 times, most recently from bcc1fad to 87de29a Compare March 24, 2025 16:51
@renovate renovate bot force-pushed the renovate/github.com-onsi-ginkgo-v2-2.x branch from 87de29a to e879614 Compare March 24, 2025 17:50
| datasource | package                   | from    | to      |
| ---------- | ------------------------- | ------- | ------- |
| go         | github.com/onsi/ginkgo/v2 | v2.23.0 | v2.23.3 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/github.com-onsi-ginkgo-v2-2.x branch from e879614 to 8ddddd8 Compare March 24, 2025 18:10
@renovate renovate bot changed the title Update module github.com/onsi/ginkgo/v2 to v2.23.3 Update module github.com/onsi/ginkgo/v2 to v2.23.3 - autoclosed Mar 25, 2025
@renovate renovate bot closed this Mar 25, 2025
auto-merge was automatically disabled March 25, 2025 03:43

Pull request was closed

@renovate renovate bot deleted the renovate/github.com-onsi-ginkgo-v2-2.x branch March 25, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants