Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(about): list official resources #7562

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

avivkeller
Copy link
Member

Description

This PR lists official resources on the “About” page, so that users are steered away from unofficial, and possibly dangerous, resources.

I’m not sure if the TSC needs to sign off on this, to make sure that everything that should be included is.

Validation

Check the “About” page for the added information

Related Issues

Fixes #7050

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Aviv Keller <me@aviv.sh>
@Copilot Copilot bot review requested due to automatic review settings March 22, 2025 17:25
@avivkeller avivkeller requested a review from a team as a code owner March 22, 2025 17:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/pages/en/about/index.mdx: Language not supported

Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 25, 2025 2:28pm

@avivkeller avivkeller added the content Issues/pr concerning content label Mar 22, 2025
@avivkeller
Copy link
Member Author

See the edited About page: https://nodejs-org-git-feat-official-resources-openjs.vercel.app/en/about

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovflowd
Copy link
Member

ovflowd commented Mar 22, 2025

cc @nodejs/tsc as this is content updates. I feel confident with these updates, but just pining y'all in.

### Official npm Packages

The Node.js team maintains the following official npm package scopes:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about corepack, amaro, llhttp, etc...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, these do not have any @ within npm. Good catch. @marco-ippolito do you have a full list?

Copy link
Member Author

@avivkeller avivkeller Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those packages are published under the nodejs-foundation account, which is listed right under the list of scopes

https://www.npmjs.com/~nodejs-foundation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see amaro or undici in there 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess those two weren't published from the foundation account. If you have a list of packages that belong to the organization, I'll check if they are published under the foundation account, and if not I'll add them to this list.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@avivkeller
Copy link
Member Author

avivkeller commented Mar 22, 2025

I've removed mention to other packages for now.

If it's agreed upon that they should be listed, and someone can provide a definitive list, I'll add them into this PR.

Also see nodejs/admin#959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Status Page link to README / and/or website
7 participants