We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For server-side tagging a custom src needs to be set for Google Tag Manager.
Currently this src is hard coded in:
scripts/src/runtime/registry/google-tag-manager.ts
Line 47 in f96f7b5
Whenever we want to change the src manually the ID is no longer appended, make it so we have to define the ID twice.
googleTagManager: { id: 'GTM-123456', scriptInput: { src: 'https://gtm.example.com/gtm.js?id=GTM-123456', }, },
A simple solution to the problem could be to add an option for the src.
src: withQuery(options?.src || 'https://www.googletagmanager.com/gtm.js', { id: options?.id, l: options?.l }),
Which makes it so we can easily change it like so:
googleTagManager: { id: 'GTM-123456', src: 'https://gtm.example.com/gtm.js' },
No response
The text was updated successfully, but these errors were encountered:
@Reyno-Skeps do you want to create a pull request? We need this too and otherwise I would create one
Sorry, something went wrong.
@ThiloHettmer Just submitted a PR.
Bump for awareness ;)
Related #397
This may help #434
Successfully merging a pull request may close this issue.
🆒 Your use case
For server-side tagging a custom src needs to be set for Google Tag Manager.
Currently this src is hard coded in:
scripts/src/runtime/registry/google-tag-manager.ts
Line 47 in f96f7b5
Whenever we want to change the src manually the ID is no longer appended, make it so we have to define the ID twice.
🆕 The solution you'd like
A simple solution to the problem could be to add an option for the src.
src: withQuery(options?.src || 'https://www.googletagmanager.com/gtm.js', { id: options?.id, l: options?.l }),
Which makes it so we can easily change it like so:
🔍 Alternatives you've considered
No response
ℹ️ Additional info
No response
The text was updated successfully, but these errors were encountered: