Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why sorting the nodes again when the nodes is sorted by the function speficified by the config option 'sort.sorter' #3049

Closed
zjykzk opened this issue Jan 13, 2025 · 1 comment

Comments

@zjykzk
Copy link

zjykzk commented Jan 13, 2025

why it's still to do do merge sort for prevent memory exceed when the configation of sort.sorter does return nothing

since the nodes in the variable t_users is in the order defined by the user, maybe it's better not to do that?

Best wishes!

@zjykzk zjykzk changed the title why sort the nodes again when the nodes is sorted by the function speficified by the config option 'sort.sorter' Question: why sort the nodes again when the nodes is sorted by the function speficified by the config option 'sort.sorter' Jan 13, 2025
@zjykzk zjykzk changed the title Question: why sort the nodes again when the nodes is sorted by the function speficified by the config option 'sort.sorter' Question: Why sorting the nodes again when the nodes is sorted by the function speficified by the config option 'sort.sorter' Jan 13, 2025
@alex-courtis
Copy link
Member

sort.sorter will return nothing when the user returns a value like "name", which is a Sorter method.

When they return nothing (they have sorted t_user) the merge sort will still be done.

@nvim-tree nvim-tree locked and limited conversation to collaborators Jan 17, 2025
@alex-courtis alex-courtis converted this issue into discussion #3052 Jan 17, 2025

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants