feat(speech-voice-types): add SpeechVoice and SpeechResponseFormat types #1355
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow |
guspuffygit
force-pushed
the
speech-voice-types
branch
from
f494e8f to
233830a
Compare
- Introduce new exported type aliases SpeechVoice and SpeechResponseFormat for valid voice and audio format options.
- Update SpeechCreateParams:
- Change voice field type to (string & {}) | SpeechVoice for flexibility and consistency.
- Change response_format field type to (string & {}) | SpeechResponseFormat for flexibility and consistency.
- Extend the exported namespace to include the new types.
guspuffygit
force-pushed
the
speech-voice-types
branch
from
dbd0f24 to
ed5a5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
If we could make SpeechVoice and SpeechResponseFormat types consistent with SpeechModel they can be referenced in consuming libraries. Due to them being hardcoded you can't use it as a type in consuming libraries.
Adding the (string & {}) flexibility for these types also makes it possible to use OpenAI compatible APIs.