Fix bug with Azure Async filter events processing #2255
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
When using
(Async)ChatCompletionStream
, add a weak validation before the accumulation, to ignore events not adhering to theChatCompletionChunk
schema.This prevents runtime errors when the SSEs are not 100% compatible with OpenAI spec (e.g. when using Azure OpenAI with Asynchronous Filter feature).
Before this fix, the following code will result in an error:
Additional context & links
The primary purpose of this PR is to make this SDK usable with Azure OpenAI Asynchronous Filter feature.
E.g. Langchain internally relies on
client.beta.chat.completions.stream
in some cases.An issue describing non-compatible events when using an Asynchronous Feature:
Fixes to the same problem in other popular SDK's:
Other possibly related issues:
CC @kristapratico