Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wymsee/cordova-imagePicker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ovidiubularda/cordova-imagePicker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 17 commits
  • 63 files changed
  • 1 contributor

Commits on Sep 12, 2015

  1. Copy the full SHA
    582542e View commit details
  2. Updated plugin.xml

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    c56c069 View commit details
  3. no message

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    1284413 View commit details
  4. V1.0.9

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    98a56c9 View commit details
  5. Added npm config file

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    c360d63 View commit details
  6. Update nom

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    0bbca94 View commit details
  7. v1.0.12

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    34a1a37 View commit details
  8. v1.0.13

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    9fc6294 View commit details
  9. v1.0.14

    ovidiubularda committed Sep 12, 2015
    Copy the full SHA
    b9414c3 View commit details

Commits on Sep 13, 2015

  1. Update v2

    ovidiubularda committed Sep 13, 2015
    Copy the full SHA
    de6ccf6 View commit details
  2. Update iOS files.

    ovidiubularda committed Sep 13, 2015
    Copy the full SHA
    cb77815 View commit details
  3. fix 2.0.3

    ovidiubularda committed Sep 13, 2015
    Copy the full SHA
    3cce2e8 View commit details
  4. Update version to 2.0.7

    ovidiubularda committed Sep 13, 2015
    Copy the full SHA
    ae7b36c View commit details
  5. Copy the full SHA
    4474290 View commit details

Commits on Sep 15, 2015

  1. Update - 2.0.9

    ovidiubularda committed Sep 15, 2015
    Copy the full SHA
    94c54f0 View commit details
  2. v2.0.11

    ovidiubularda committed Sep 15, 2015
    Copy the full SHA
    e95cf19 View commit details

Commits on Sep 17, 2015

  1. Up version on nom

    ovidiubularda committed Sep 17, 2015
    Copy the full SHA
    0ba5c97 View commit details
Showing with 3,085 additions and 2,230 deletions.
  1. +2 −0 .gitignore
  2. BIN .gitignore.swp
  3. +19 −21 README.md
  4. +19 −0 package.json
  5. +31 −21 plugin.xml
  6. +0 −24 src/ios/ELCImagePicker/ELCAlbumPickerController.h
  7. +0 −164 src/ios/ELCImagePicker/ELCAlbumPickerController.m
  8. +0 −29 src/ios/ELCImagePicker/ELCAsset.h
  9. +0 −49 src/ios/ELCImagePicker/ELCAsset.m
  10. +0 −15 src/ios/ELCImagePicker/ELCAssetCell.h
  11. +0 −117 src/ios/ELCImagePicker/ELCAssetCell.m
  12. +0 −12 src/ios/ELCImagePicker/ELCAssetPickerFilterDelegate.h
  13. +0 −18 src/ios/ELCImagePicker/ELCAssetSelectionDelegate.h
  14. +0 −31 src/ios/ELCImagePicker/ELCAssetTablePicker.h
  15. +0 −217 src/ios/ELCImagePicker/ELCAssetTablePicker.m
  16. +0 −48 src/ios/ELCImagePicker/ELCImagePickerController.h
  17. +0 −95 src/ios/ELCImagePicker/ELCImagePickerController.m
  18. +0 −374 src/ios/ELCImagePicker/Resources/ELCAlbumPickerController.xib
  19. +0 −435 src/ios/ELCImagePicker/Resources/ELCAssetPicker.xib
  20. +0 −422 src/ios/ELCImagePicker/Resources/ELCAssetTablePicker.xib
  21. BIN src/ios/ELCImagePicker/Resources/Overlay.png
  22. BIN src/ios/ELCImagePicker/Resources/Overlay@2x.png
  23. +26 −0 src/ios/QBImagePicker/Info.plist
  24. +21 −0 src/ios/QBImagePicker/QBAlbumCell.h
  25. +27 −0 src/ios/QBImagePicker/QBAlbumCell.m
  26. +17 −0 src/ios/QBImagePicker/QBAlbumsViewController.h
  27. +389 −0 src/ios/QBImagePicker/QBAlbumsViewController.m
  28. +20 −0 src/ios/QBImagePicker/QBAssetCell.h
  29. +27 −0 src/ios/QBImagePicker/QBAssetCell.m
  30. +19 −0 src/ios/QBImagePicker/QBAssetsViewController.h
  31. +661 −0 src/ios/QBImagePicker/QBAssetsViewController.m
  32. +21 −0 src/ios/QBImagePicker/QBCheckmarkView.h
  33. +54 −0 src/ios/QBImagePicker/QBCheckmarkView.m
  34. +18 −0 src/ios/QBImagePicker/QBImagePicker.h
  35. +293 −0 src/ios/QBImagePicker/QBImagePicker.storyboard
  36. +51 −0 src/ios/QBImagePicker/QBImagePickerController.h
  37. +77 −0 src/ios/QBImagePicker/QBImagePickerController.m
  38. +16 −0 src/ios/QBImagePicker/QBSlomoIconView.h
  39. +36 −0 src/ios/QBImagePicker/QBSlomoIconView.m
  40. +16 −0 src/ios/QBImagePicker/QBVideoIconView.h
  41. +38 −0 src/ios/QBImagePicker/QBVideoIconView.m
  42. +21 −0 src/ios/QBImagePicker/QBVideoIndicatorView.h
  43. +28 −0 src/ios/QBImagePicker/QBVideoIndicatorView.m
  44. +21 −0 src/ios/QBImagePicker/de.lproj/QBImagePicker.strings
  45. +21 −0 src/ios/QBImagePicker/en.lproj/QBImagePicker.strings
  46. +21 −0 src/ios/QBImagePicker/es.lproj/QBImagePicker.strings
  47. +21 −0 src/ios/QBImagePicker/ja.lproj/QBImagePicker.strings
  48. +21 −0 src/ios/QBImagePicker/zh-Hans.lproj/QBImagePicker.strings
  49. +7 −5 src/ios/SOSPicker.h
  50. +66 −132 src/ios/SOSPicker.m
  51. +531 −0 test/imagepicker/imagepicker.xcodeproj/project.pbxproj
  52. +17 −0 test/imagepicker/imagepicker/AppDelegate.h
  53. +45 −0 test/imagepicker/imagepicker/AppDelegate.m
  54. +41 −0 test/imagepicker/imagepicker/Base.lproj/LaunchScreen.xib
  55. +36 −0 test/imagepicker/imagepicker/Base.lproj/Main.storyboard
  56. +38 −0 test/imagepicker/imagepicker/Images.xcassets/AppIcon.appiconset/Contents.json
  57. +40 −0 test/imagepicker/imagepicker/Info.plist
  58. +17 −0 test/imagepicker/imagepicker/ViewController.h
  59. +113 −0 test/imagepicker/imagepicker/ViewController.m
  60. +16 −0 test/imagepicker/imagepicker/main.m
  61. +24 −0 test/imagepicker/imagepickerTests/Info.plist
  62. +40 −0 test/imagepicker/imagepickerTests/imagepickerTests.m
  63. +2 −1 www/imagepicker.js
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.idea
.DS_Store
/build
# XCode (and ancestors) per-user config (very noisy, and not relevant)
@@ -12,3 +13,4 @@
xcuserdata/
project.xcworkspace/
tags
test
Binary file added .gitignore.swp
Binary file not shown.
40 changes: 19 additions & 21 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
cordova-imagePicker
cordova-obimagepicker
===================

Cordova Plugin For Multiple Image Selection - implemented for iOS and Android 4.0 and above.
It can be used as a replacement for http://ngcordova.com/docs/plugins/imagePicker/

* exports images in Base64 format

## Installing the plugin

The plugin conforms to the Cordova plugin specification, it can be installed
using the Cordova / Phonegap command line interface.

phonegap plugin add https://github.com/wymsee/cordova-imagePicker.git

cordova plugin add https://github.com/wymsee/cordova-imagePicker.git
phonegap plugin add cordova-obimagepicker
cordova plugin add cordova-obimagepicker


## Using the plugin
@@ -41,28 +43,18 @@ window.imagePicker.getPictures(
console.log('Error: ' + error);
}, {
maximumImagesCount: 10,
width: 800
width: 100 // Set with for image - will keep the aspect ratio
}
);
```

### Options

options = {
// max images to be selected, defaults to 15. If this is set to 1, upon
// selection of a single image, the plugin will return it.
// max images to be selected, defaults to 0 (infinity)
maximumImagesCount: int,
// max width and height to allow the images to be. Will keep aspect
// ratio no matter what. So if both are 800, the returned image
// will be at most 800 pixels wide and 800 pixels tall. If the width is
// 800 and height 0 the image will be 800 pixels wide if the source
// is at least that wide.
width: int,
height: int,
// quality of resized image, defaults to 100
quality: int (0-100)
// set with of the new returned image - will keep the aspect ratio
width: int
};

### Note for Android Use
@@ -71,11 +63,17 @@ The plugin returns images that are stored in a temporary directory. These image

## Libraries used

#### ELCImagePicker
#### QBImagePicker

For iOS this plugin uses the QBImagePicker, with slight modifications for the iOS image picker.
QBImagePicker uses the MIT License which can be found in the file LICENSE.

### The following libraries are required:
- QuartzCore.framework
- Photos.framework

For iOS this plugin uses the ELCImagePickerController, with slight modifications for the iOS image picker. ELCImagePicker uses the MIT License which can be found in the file LICENSE.

https://github.com/B-Sides/ELCImagePickerController
https://github.com/questbeat/QBImagePicker

#### MultiImageChooser

19 changes: 19 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "cordova-obimagepicker",
"version": "2.0.13",
"description": "Cordova file picker",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": {
"type": "git",
"url": "git+https://ovidiubularda@github.com/ovidiubularda/cordova-imagePicker.git"
},
"author": "Ovidiu Bularda",
"license": "ISC",
"bugs": {
"url": "https://github.com/ovidiubularda/cordova-imagePicker/issues"
},
"homepage": "https://github.com/ovidiubularda/cordova-imagePicker#readme"
}
52 changes: 31 additions & 21 deletions plugin.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="com.synconset.imagepicker"
version="1.0.6">
id="ro.qualitance.obimagepicker"
version="2.0.13">

<name>ImagePicker</name>
<name>ObImagePicker</name>

<description>
This plugin allows selection of multiple images from the camera roll / gallery in a phonegap app
@@ -31,36 +31,46 @@
<header-file src="src/ios/SOSPicker.h" />
<source-file src="src/ios/SOSPicker.m" />

<header-file src="src/ios/ELCImagePicker/ELCAlbumPickerController.h" />
<source-file src="src/ios/ELCImagePicker/ELCAlbumPickerController.m" />
<header-file src="src/ios/QBImagePicker/QBAlbumCell.h" />
<source-file src="src/ios/QBImagePicker/QBAlbumCell.m" />

<header-file src="src/ios/ELCImagePicker/ELCAsset.h" />
<source-file src="src/ios/ELCImagePicker/ELCAsset.m" />
<header-file src="src/ios/QBImagePicker/QBAlbumsViewController.h" />
<source-file src="src/ios/QBImagePicker/QBAlbumsViewController.m" />

<header-file src="src/ios/ELCImagePicker/ELCAssetCell.h" />
<source-file src="src/ios/ELCImagePicker/ELCAssetCell.m" />
<header-file src="src/ios/QBImagePicker/QBAssetCell.h" />
<source-file src="src/ios/QBImagePicker/QBAssetCell.m" />

<header-file src="src/ios/ELCImagePicker/ELCAssetPickerFilterDelegate.h" />
<header-file src="src/ios/ELCImagePicker/ELCAssetSelectionDelegate.h" />
<header-file src="src/ios/QBImagePicker/QBAssetsViewController.h" />
<source-file src="src/ios/QBImagePicker/QBAssetsViewController.m" />

<header-file src="src/ios/ELCImagePicker/ELCAssetTablePicker.h" />
<source-file src="src/ios/ELCImagePicker/ELCAssetTablePicker.m" />
<header-file src="src/ios/QBImagePicker/QBCheckmarkView.h" />
<source-file src="src/ios/QBImagePicker/QBCheckmarkView.m" />

<header-file src="src/ios/ELCImagePicker/ELCImagePickerController.h" />
<source-file src="src/ios/ELCImagePicker/ELCImagePickerController.m" />
<header-file src="src/ios/QBImagePicker/QBImagePicker.h" />

<header-file src="src/ios/QBImagePicker/QBImagePickerController.h" />
<source-file src="src/ios/QBImagePicker/QBImagePickerController.m" />

<header-file src="src/ios/QBImagePicker/QBSlomoIconView.h" />
<source-file src="src/ios/QBImagePicker/QBSlomoIconView.m" />

<header-file src="src/ios/QBImagePicker/QBVideoIconView.h" />
<source-file src="src/ios/QBImagePicker/QBVideoIconView.m" />

<header-file src="src/ios/QBImagePicker/QBVideoIndicatorView.h" />
<source-file src="src/ios/QBImagePicker/QBVideoIndicatorView.m" />


<resource-file src="src/ios/QBImagePicker/QBImagePicker.storyboard" />
<resource-file src="src/ios/QBImagePicker/en.lproj/QBImagePicker.strings" />

<resource-file src="src/ios/ELCImagePicker/Resources/ELCAlbumPickerController.xib" />
<resource-file src="src/ios/ELCImagePicker/Resources/ELCAssetPicker.xib" />
<resource-file src="src/ios/ELCImagePicker/Resources/ELCAssetTablePicker.xib" />
<resource-file src="src/ios/ELCImagePicker/Resources/Overlay.png" />
<resource-file src="src/ios/ELCImagePicker/Resources/Overlay@2x.png" />
</platform>

<!-- android -->
<platform name="android">
<config-file target="res/xml/config.xml" parent="/*">
<feature name="ImagePicker">
<param name="android-package" value="com.synconset.ImagePicker"/>
<param name="android-package" value="ro.qualitance.obimagepicker"/>
</feature>
</config-file>

24 changes: 0 additions & 24 deletions src/ios/ELCImagePicker/ELCAlbumPickerController.h

This file was deleted.

164 changes: 0 additions & 164 deletions src/ios/ELCImagePicker/ELCAlbumPickerController.m

This file was deleted.

Loading