Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bump prettier from 2.0.5 to 3.5.3 #9671

Open
wants to merge 6 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Mar 22, 2025

Pull Request

Issue

Closes: #9625

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

dependabot bot and others added 2 commits March 21, 2025 13:20
Bumps [prettier](https://github.com/prettier/prettier) from 2.0.5 to 3.5.3.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.0.5...3.5.3)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link

parse-github-assistant bot commented Mar 22, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.08%. Comparing base (042a920) to head (ac2c36e).

Files with missing lines Patch % Lines
src/SchemaMigrations/DefinedSchemas.js 55.55% 4 Missing ⚠️
src/Auth.js 75.00% 1 Missing ⚠️
src/Controllers/SchemaController.js 90.00% 1 Missing ⚠️
src/Routers/GraphQLRouter.js 0.00% 1 Missing ⚠️
src/middlewares.js 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9671      +/-   ##
==========================================
- Coverage   93.10%   93.08%   -0.03%     
==========================================
  Files         187      187              
  Lines       15016    15044      +28     
==========================================
+ Hits        13981    14003      +22     
- Misses       1035     1041       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza changed the title Feature/update prettier refactor: Bump prettier from 2.0.5 to 3.5.3 Mar 23, 2025
@mtrezza
Copy link
Member

mtrezza commented Mar 23, 2025

What did this PR require? Only upgrading the dependency? I thought it was more because the definitions check failed.

I assume all the other changes are because you ran lint:fix?

@dblythy
Copy link
Member Author

dblythy commented Mar 24, 2025

I upgraded the dependency and ran prettier + lint

@mtrezza
Copy link
Member

mtrezza commented Mar 27, 2025

I think we need to be careful running prettier across the whole code base. It could disrupt existing PRs, because the rebase may be difficult. We also have no automation in place to ensure prettier before merge, so this is a continuing cicle. A pre-commit hook is not a good solution. I'd suggest to run prettier --check in the CI, just like we do for lint.

Interestingly, I ran npm run prettier && npm run lint-fix and get many changes. I think it's unlikely that they all come from the last few alpha merges:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants