auto trigger creation on create_hash_partitions() and create_range_partitions() if upper parent has trigger

Author: zilder

hash.sql

@@ -20,6 +20,9 @@ CREATE OR REPLACE FUNCTION @extschema@.create_hash_partitions(
 	tablespaces			TEXT[] DEFAULT NULL)
 RETURNS INTEGER AS
 $$
+DECLARE
+	v_upper_parent		REGCLASS;
+
 BEGIN
 	PERFORM @extschema@.validate_relname(parent_relid);
 
@@ -45,6 +48,16 @@ BEGIN
 														partition_names,
 														tablespaces);
 
+	/*
+	 * If there is an upper level parent partitioned by pg_pathman and it has
+	 * update triggers then create them too
+	 */
+	v_upper_parent = @extschema@.get_parent_of_partition(parent_relid, false);
+	IF NOT v_upper_parent IS NULL AND @extschema@.has_update_trigger(v_upper_parent)
+	THEN
+		PERFORM @extschema@.create_update_triggers(parent_relid);
+	END IF;
+
 	/* Copy data */
 	IF partition_data = true THEN
 		PERFORM @extschema@.set_enable_parent(parent_relid, false);

init.sql

@@ -533,7 +533,8 @@ LANGUAGE plpgsql;
  * Drop triggers
  */
 CREATE OR REPLACE FUNCTION @extschema@.drop_triggers(
-	parent_relid	REGCLASS)
+	parent_relid	REGCLASS,
+	force			BOOL DEFAULT FALSE)
 RETURNS VOID AS 'pg_pathman', 'drop_update_triggers'
 LANGUAGE C STRICT;
 
@@ -560,7 +561,7 @@ BEGIN
 	PERFORM @extschema@.prevent_relation_modification(parent_relid);
 
 	/* First, drop all triggers */
-	PERFORM @extschema@.drop_triggers(parent_relid);
+	PERFORM @extschema@.drop_triggers(parent_relid, TRUE);
 
 	SELECT count(*) FROM @extschema@.pathman_config
 	WHERE partrel = parent_relid INTO conf_num;

range.sql

@@ -103,6 +103,7 @@ DECLARE
 	end_value		start_value%TYPE;
 	part_count		INTEGER := 0;
 	i				INTEGER;
+	v_upper_parent	REGCLASS;
 
 BEGIN
 	expression := lower(expression);
@@ -171,6 +172,16 @@ BEGIN
 									NULL);
 	END IF;
 
+	/*
+	 * If there is an upper level parent partitioned by pg_pathman and it has
+	 * update triggers then create them too
+	 */
+	v_upper_parent = @extschema@.get_parent_of_partition(parent_relid, false);
+	IF NOT v_upper_parent IS NULL AND @extschema@.has_update_trigger(v_upper_parent)
+	THEN
+		PERFORM @extschema@.create_update_triggers(parent_relid);
+	END IF;
+
 	/* Relocate data if asked to */
 	IF partition_data = true THEN
 		PERFORM @extschema@.set_enable_parent(parent_relid, false);
@@ -202,6 +213,7 @@ DECLARE
 	end_value		start_value%TYPE;
 	part_count		INTEGER := 0;
 	i				INTEGER;
+	v_upper_parent	REGCLASS;
 
 BEGIN
 	expression := lower(expression);
@@ -267,6 +279,16 @@ BEGIN
 						NULL);
 	END IF;
 
+	/*
+	 * If there is an upper level parent partitioned by pg_pathman and it has
+	 * update triggers then create them too
+	 */
+	v_upper_parent = @extschema@.get_parent_of_partition(parent_relid, false);
+	IF NOT v_upper_parent IS NULL AND @extschema@.has_update_trigger(v_upper_parent)
+	THEN
+		PERFORM @extschema@.create_update_triggers(parent_relid);
+	END IF;
+
 	/* Relocate data if asked to */
 	IF partition_data = true THEN
 		PERFORM @extschema@.set_enable_parent(parent_relid, false);

src/partition_creation.c

@@ -25,6 +25,7 @@
 #include "catalog/pg_trigger.h"
 #include "catalog/pg_type.h"
 #include "catalog/toasting.h"
+#include "commands/defrem.h"
 #include "commands/event_trigger.h"
 #include "commands/sequence.h"
 #include "commands/tablecmds.h"
@@ -1823,9 +1824,17 @@ void
 drop_single_update_trigger_internal(Oid relid,
 									const char *trigname)
 {
-	Oid				trigoid;
-
-	trigoid = get_trigger_oid(relid, trigname, true);
-	if (OidIsValid(trigoid))
-		RemoveTriggerById(trigoid);
+	DropStmt	   *n = makeNode(DropStmt);
+	const char	   *relname = get_qualified_rel_name(relid);
+	List		   *namelist = stringToQualifiedNameList(relname);
+
+	namelist = lappend(namelist, makeString((char *) trigname));
+	n->removeType	= OBJECT_TRIGGER;
+	n->missing_ok	= true;
+	n->objects		= list_make1(namelist);
+	n->arguments	= NIL;
+	n->behavior		= DROP_RESTRICT;  /* default behavior */
+	n->concurrent	= false;
+
+	RemoveObjects(n);
 }

src/pl_funcs.c

@@ -1607,20 +1607,24 @@ drop_update_triggers(PG_FUNCTION_ARGS)
 	Oid					relid = PG_GETARG_OID(0),
 						parent;
 	PartParentSearch	parent_search;
+	bool				force = PG_GETARG_BOOL(1);
 
-	/*
-	 * We can drop triggers only if relid is the topmost parent table (or if
-	 * its parent doesn't have update triggers (which should never happen in
-	 * the ideal world)
-	 */
-	parent = get_parent_of_partition(relid, &parent_search);
-	if (parent_search == PPS_ENTRY_PART_PARENT)
-		if(has_update_trigger_internal(parent))
-			ereport(ERROR,
-					(errmsg("Parent table must not have an update trigger"),
-					 errhint("Try to perform SELECT %s.drop_triggers('%s');",
-							 get_namespace_name(get_pathman_schema()),
-							 get_qualified_rel_name(parent))));
+	if (!force)
+	{
+		/*
+		 * We can drop triggers only if relid is the topmost parent table (or if
+		 * its parent doesn't have update triggers (which should never happen in
+		 * the ideal world)
+		 */
+		parent = get_parent_of_partition(relid, &parent_search);
+		if (parent_search == PPS_ENTRY_PART_PARENT)
+			if(has_update_trigger_internal(parent))
+				ereport(ERROR,
+						(errmsg("Parent table must not have an update trigger"),
+						 errhint("Try to perform SELECT %s.drop_triggers('%s');",
+								 get_namespace_name(get_pathman_schema()),
+								 get_qualified_rel_name(parent))));
+	}
 
 	/* Recursively drop triggers */
 	drop_update_triggers_internal(relid);