revisit some TODOs

funbringer · funbringer · commit cf28b4ef0b95 · 2018-06-22T18:39:11.000+03:00
diff --git a/src/hooks.c b/src/hooks.c
@@ -484,10 +484,6 @@ pathman_rel_pathlist_hook(PlannerInfo *root,
 
 	parent_rowmark = get_plan_rowmark(root->rowMarks, rti);
 
-	/*
-	 * WARNING: 'prel' might become invalid after append_child_relation().
-	 */
-
 	/* Add parent if asked to */
 	if (prel->enable_parent)
 		append_child_relation(root, parent_rel, parent_rowmark,
diff --git a/src/init.c b/src/init.c
@@ -665,7 +665,7 @@ pathman_config_contains_relation(Oid relid, Datum *values, bool *isnull,
 
 		/* Set ItemPointer if necessary */
 		if (iptr)
-			*iptr = htup->t_self;
+			*iptr = htup->t_self; /* FIXME: callers should lock table beforehand */
 	}
 
 	/* Clean resources */

Original file line number	Diff line number	Diff line change
`@@ -665,7 +665,7 @@ pathman_config_contains_relation(Oid relid, Datum values, bool isnull,`
`665`	`665`
`666`	`666`	`/* Set ItemPointer if necessary */`
`667`	`667`	`if (iptr)`
`668`		`- *iptr = htup->t_self;`
	`668`	`+ iptr = htup->t_self; / FIXME: callers should lock table beforehand */`
`669`	`669`	`}`
`670`	`670`
`671`	`671`	`/* Clean resources */`