WIP some fundamental changes to caches

Author: funbringer

Diff for: src/hooks.c

@@ -812,60 +812,36 @@ pathman_shmem_startup_hook(void)
 void
 pathman_relcache_hook(Datum arg, Oid relid)
 {
-	Oid parent_relid;
-
 	/* See cook_partitioning_expression() */
 	if (!pathman_hooks_enabled)
 		return;
 
 	if (!IsPathmanReady())
 		return;
 
-	/* Special case: flush whole relcache */
+	/* Invalidation event for whole cache */
 	if (relid == InvalidOid)
 	{
-		delay_invalidation_whole_cache();
-
-#ifdef USE_RELCACHE_LOGGING
-		elog(DEBUG2, "Invalidation message for all relations [%u]", MyProcPid);
-#endif
-
-		return;
+		invalidate_pathman_status_info_cache();
 	}
 
-	/* We shouldn't even consider special OIDs */
-	if (relid < FirstNormalObjectId)
-		return;
-
 	/* Invalidation event for PATHMAN_CONFIG table (probably DROP) */
 	if (relid == get_pathman_config_relid(false))
+	{
 		delay_pathman_shutdown();
+	}
 
-	/* Invalidate PartBoundInfo cache if needed */
-	forget_bounds_of_partition(relid);
-
-	/* Invalidate PartParentInfo cache if needed */
-	parent_relid = forget_parent_of_partition(relid, NULL);
-
-	/* It *might have been a partition*, invalidate parent */
-	if (OidIsValid(parent_relid))
+	/* Invalidation event for some user table */
+	else if (relid >= FirstNormalObjectId)
 	{
-		delay_invalidation_parent_rel(parent_relid);
+		/* Invalidate PartBoundInfo entry if needed */
+		forget_bounds_of_partition(relid);
 
-#ifdef USE_RELCACHE_LOGGING
-		elog(DEBUG2, "Invalidation message for partition %u [%u]",
-			 relid, MyProcPid);
-#endif
-	}
-	/* We can't say, perform full invalidation procedure */
-	else
-	{
-		delay_invalidation_vague_rel(relid);
+		/* Invalidate PartParentInfo entry if needed */
+		forget_parent_of_partition(relid);
 
-#ifdef USE_RELCACHE_LOGGING
-		elog(DEBUG2, "Invalidation message for vague rel %u [%u]",
-			 relid, MyProcPid);
-#endif
+		/* Invalidate PartStatusInfo entry if needed */
+		invalidate_pathman_status_info(relid);
 	}
 }
 

Diff for: src/include/init.h

@@ -46,22 +46,21 @@ typedef struct
 	do { \
 		Assert(CurrentMemoryContext != TopMemoryContext); \
 		Assert(CurrentMemoryContext != TopPathmanContext); \
-		Assert(CurrentMemoryContext != PathmanRelationCacheContext); \
-		Assert(CurrentMemoryContext != PathmanParentCacheContext); \
-		Assert(CurrentMemoryContext != PathmanBoundCacheContext); \
+		Assert(CurrentMemoryContext != PathmanParentsCacheContext); \
+		Assert(CurrentMemoryContext != PathmanStatusCacheContext); \
+		Assert(CurrentMemoryContext != PathmanBoundsCacheContext); \
 	} while (0)
 
 
 #define PATHMAN_MCXT_COUNT	4
 extern MemoryContext		TopPathmanContext;
-extern MemoryContext		PathmanInvalJobsContext;
-extern MemoryContext		PathmanRelationCacheContext;
-extern MemoryContext		PathmanParentCacheContext;
-extern MemoryContext		PathmanBoundCacheContext;
+extern MemoryContext		PathmanParentsCacheContext;
+extern MemoryContext		PathmanStatusCacheContext;
+extern MemoryContext		PathmanBoundsCacheContext;
 
-extern HTAB				   *partitioned_rels;
-extern HTAB				   *parent_cache;
-extern HTAB				   *bound_cache;
+extern HTAB				   *parents_cache;
+extern HTAB				   *status_cache;
+extern HTAB				   *bounds_cache;
 
 /* pg_pathman's initialization state */
 extern PathmanInitState 	pathman_init_state;
@@ -70,28 +69,29 @@ extern PathmanInitState 	pathman_init_state;
 extern bool					pathman_hooks_enabled;
 
 
+#define PATHMAN_TOP_CONTEXT		"maintenance"
+#define PATHMAN_PARENTS_CACHE	"partition parents cache"
+#define PATHMAN_STATUS_CACHE	"partition status cache"
+#define PATHMAN_BOUNDS_CACHE	"partition bounds cache"
+
+
 /* Transform pg_pathman's memory context into simple name */
 static inline const char *
-simpify_mcxt_name(MemoryContext mcxt)
+simplify_mcxt_name(MemoryContext mcxt)
 {
-	static const char  *top_mcxt	= "maintenance",
-					   *rel_mcxt	= "partition dispatch cache",
-					   *parent_mcxt	= "partition parents cache",
-					   *bound_mcxt	= "partition bounds cache";
-
 	if (mcxt == TopPathmanContext)
-		return top_mcxt;
+		return PATHMAN_TOP_CONTEXT;
 
-	else if (mcxt == PathmanRelationCacheContext)
-		return rel_mcxt;
+	else if (mcxt == PathmanParentsCacheContext)
+		return PATHMAN_PARENTS_CACHE;
 
-	else if (mcxt == PathmanParentCacheContext)
-		return parent_mcxt;
+	else if (mcxt == PathmanStatusCacheContext)
+		return PATHMAN_STATUS_CACHE;
 
-	else if (mcxt == PathmanBoundCacheContext)
-		return bound_mcxt;
+	else if (mcxt == PathmanBoundsCacheContext)
+		return PATHMAN_BOUNDS_CACHE;
 
-	else elog(ERROR, "error in function " CppAsString(simpify_mcxt_name));
+	else elog(ERROR, "unknown memory context");
 }