Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __all__ part 2 #13719

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add __all__ part 2 #13719

wants to merge 8 commits into from
+1,057 −171

Conversation

donBarbos
Copy link
Contributor

only # TODO: missing from stub remained, which require some thought to solve :)

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@donBarbos donBarbos marked this pull request as ready for review March 25, 2025 22:29
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Avasam
Avasam reviewed Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@Avasam Avasam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this.
I'll just trust stubtest for the actual content of __all__.
Great job overall, I have a few small comments.

Avasam

This comment was marked as duplicate.

Sign in to view

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Avasam
Avasam approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasam Avasam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donBarbos @Avasam