Show Whole Command on Tracing #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rodneyosodo , thank you for contributing. Do you have more context on why the limit was added? If no, I can check later this week. |
|
Hello @ndyakov I don't have context as to why the limit was added. |
|
@monkey92t it doesn't look like this can break anything. Do you remember why the limits were introduced? |
rodneyosodo
force-pushed
the
show-whole-command
branch
from
5209dfa to
68606e0
Compare
Truncate version of a long key might not be useful when debugging Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
rodneyosodo
force-pushed
the
show-whole-command
branch
from
8c1356b to
6ad9c42
Compare
|
I think it was just to avoid overly long data that a portion was trimmed, and there’s no other evidence at the moment. |
ndyakov
approved these changes
Mar 17, 2025
|
@monkey92t @rodneyosodo then this looks safe to be merged once the CI completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes previously imposed limits on command handling in the Redis command processing module and adds tests for tracing hooks involving long commands and arguments. In the
rediscmd.gofile, the constants limiting command count, argument count, and argument length have been removed, allowing the processing of all elements in the input. In thetracing_test.gofile, two new tests are introduced to verify that the tracing hooks correctly capture spans for long commands and pipelines.