Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure triagebot to accept codegen-{gcc,cranelift} ping groups and document ping groups and ping commands #138120

Closed
wants to merge 2 commits into from
Closed

Configure triagebot to accept codegen-{gcc,cranelift} ping groups and document ping groups and ping commands #138120

wants to merge 2 commits into from

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Mar 6, 2025 •
edited
Loading

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@jieyouxu jieyouxu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 6, 2025

@rustbot blocked (rust-lang/team#1685)

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 6, 2025
@jieyouxu jieyouxu mentioned this pull request Mar 6, 2025
Closed
jieyouxu
jieyouxu commented Mar 6, 2025
View reviewed changes
Urgau
Urgau reviewed Mar 6, 2025
View reviewed changes
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 6, 2025 •
edited
Loading

I'm probably going to not add those aliases (more ways to do the same thing becomes even more confusing).

@jieyouxu jieyouxu force-pushed the cg_backend_ping_groups branch from 344cff3 to 1ae5bb0 Compare March 8, 2025 01:37
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 8, 2025

I dropped the aliases to avoid more ways to do the same thing to avoid it getting more confusing.

@jieyouxu jieyouxu mentioned this pull request Mar 8, 2025
Closed
4 tasks
@RalfJung
Copy link
Member

RalfJung commented Mar 10, 2025 •
edited
Loading

The name seems inconsistent with the LLVM backend ping group which is @rustbot ping llvm (not codegen-llvm).

@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 10, 2025 •
edited
Loading

@RalfJung you also fell for the classic "llvm" ping group trap 😆

It is not. llvm is an alias for llvm icebreakers ping group, see

https://github.com/rust-lang/rust/blob/master/triagebot.toml#L48-L49

this was brought up in wg-llvm zulip thread before since I've made this same mistake of thinking llvm pings wg-llvm (that we should retire the icebreakers ping group and redirect llvm to ping wg-llvm)

-- #138120 (comment)

@RalfJung
Copy link
Member

RalfJung commented Mar 10, 2025 •
edited
Loading

https://rustc-dev-guide.rust-lang.org/notification-groups/llvm.html doesn't say it has anything to do with icebreakers. Was the meaning of that name changed at some point?

@jieyouxu
Copy link
Member Author

Possibly, but that might've been a while ago

@jieyouxu jieyouxu mentioned this pull request Mar 20, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 20, 2025
@matthiaskrgr
Rollup merge of rust-lang#138735 - jieyouxu:drop-llvm-alias, r=nikic
b79f816 
Remove `llvm` and `llvms` triagebot ping aliases for `icebreakers-llvm` ping group

Because it's way too easy to confuse LLVM Icebreakers ping group versus trying to ping WG-llvm.
And AFAIK, icebreakers-llvm isn't really used in a good while.

I also fixed the rustc-dev-guide docs about ``@rustbot` ping llvm` (and changed that to the raw ping group name ``@rustbot` icebreakers-llvm`) because it's very confusing.

Previously discussed in [#t-compiler/wg-llvm > Ping group renaming](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Ping.20group.20renaming/with/453005029).

FYI `@rust-lang/wg-llvm`
FYI `@RalfJung` (since you asked in rust-lang#138120 (comment))
r? `@nikic` (or wg-llvm)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 20, 2025
@matthiaskrgr
Rollup merge of rust-lang#138735 - jieyouxu:drop-llvm-alias, r=nikic
4a87516 
Remove `llvm` and `llvms` triagebot ping aliases for `icebreakers-llvm` ping group

Because it's way too easy to confuse LLVM Icebreakers ping group versus trying to ping WG-llvm.
And AFAIK, icebreakers-llvm isn't really used in a good while.

I also fixed the rustc-dev-guide docs about ```@rustbot`` ping llvm` (and changed that to the raw ping group name ```@rustbot`` icebreakers-llvm`) because it's very confusing.

Previously discussed in [#t-compiler/wg-llvm > Ping group renaming](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Ping.20group.20renaming/with/453005029).

FYI ``@rust-lang/wg-llvm``
FYI ``@RalfJung`` (since you asked in rust-lang#138120 (comment))
r? ``@nikic`` (or wg-llvm)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2025
@rust-timer
Unrolled build for rust-lang#138735
d5a1c4f 
Rollup merge of rust-lang#138735 - jieyouxu:drop-llvm-alias, r=nikic

Remove `llvm` and `llvms` triagebot ping aliases for `icebreakers-llvm` ping group

Because it's way too easy to confuse LLVM Icebreakers ping group versus trying to ping WG-llvm.
And AFAIK, icebreakers-llvm isn't really used in a good while.

I also fixed the rustc-dev-guide docs about ``@rustbot` ping llvm` (and changed that to the raw ping group name ``@rustbot` icebreakers-llvm`) because it's very confusing.

Previously discussed in [#t-compiler/wg-llvm > Ping group renaming](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Ping.20group.20renaming/with/453005029).

FYI `@rust-lang/wg-llvm`
FYI `@RalfJung` (since you asked in rust-lang#138120 (comment))
r? `@nikic` (or wg-llvm)
@jieyouxu jieyouxu mentioned this pull request Mar 21, 2025
Open
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 24, 2025
@matthiaskrgr
Rollup merge of #138735 - jieyouxu:drop-llvm-alias, r=nikic
38d0d9e 
Remove `llvm` and `llvms` triagebot ping aliases for `icebreakers-llvm` ping group

Because it's way too easy to confuse LLVM Icebreakers ping group versus trying to ping WG-llvm.
And AFAIK, icebreakers-llvm isn't really used in a good while.

I also fixed the rustc-dev-guide docs about ``@rustbot` ping llvm` (and changed that to the raw ping group name ``@rustbot` icebreakers-llvm`) because it's very confusing.

Previously discussed in [#t-compiler/wg-llvm > Ping group renaming](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Ping.20group.20renaming/with/453005029).

FYI `@rust-lang/wg-llvm`
FYI `@RalfJung` (since you asked in rust-lang/rust#138120 (comment))
r? `@nikic` (or wg-llvm)
@jieyouxu
Copy link
Member Author

rustc-dev-guide.rust-lang.org/notification-groups/llvm.html doesn't say it has anything to do with icebreakers. Was the meaning of that name changed at some point?

FTR, this has now been removed in #138735 and the ping group docs were updated to reflect that the llvm alias is no longer a thing.

@jieyouxu
Copy link
Member Author

Apparently only team members or certain WG-* members can use @rustbot ping xxx, which means this is entirely useless.

@jieyouxu jieyouxu closed this Mar 26, 2025
@jieyouxu jieyouxu deleted the cg_backend_ping_groups branch March 26, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau

Assignees
No one assigned
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for setting up codegen backend ping groups
4 participants
@jieyouxu @RalfJung @Urgau @rustbot