Ensure non-empty buffers for large vectored I/O #138879
Open
+111
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readv
andwritev
are constrained by a platform-specific upper bound on the number of buffers which can be passed. Currently,read_vectored
andwrite_vectored
implementations simply truncate to this limit when larger. However, when the only non-empty buffers are at indices above this limit, they will erroneously returnOk(0)
.Instead, slice the buffers starting at the first non-empty buffer. This trades a conditional move for a branch, so it's barely a penalty in the common case.
The new method
limit_slices
onIoSlice
andIoSliceMut
may be generally useful to users likeadvance_slices
is, but I have left it aspub(crate)
for now.