Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9 implemented: new optional prop "target" which is the id of the scrollable container #32

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

xehpuk
Copy link
Contributor

@xehpuk xehpuk commented Jul 3, 2018

Falls back to document.documentElement / document.body if omitted.

@bySabi
Copy link
Collaborator

bySabi commented Jul 3, 2018

It looks very good. 👍
Will be great is we can add a little demo component to current example repo too.

@xehpuk, Would you like to be added as a maintainer to this project?

@bySabi bySabi merged commit 02e6140 into some-react-components:master Jul 3, 2018
@bySabi
Copy link
Collaborator

bySabi commented Jul 3, 2018

@xehpuk can you provide me some example repo with new target feature ?

I will like to test some use case before update npm

@xehpuk
Copy link
Contributor Author

xehpuk commented Jul 4, 2018

Sure! Today, while testing, I observed that I've broken cross-browser compatibility. A new PR incoming soon …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants