DefaultSimpUserRegistry Use ReentrantLock to Prevent Pinning #34538
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SeungHun Choi <csh0034@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
pankratz76
reviewed
Mar 22, 2025
Comment on lines
+116
to
+117
|
|
||
| this.sessionLock.lock(); |
There was a problem hiding this comment.
Suggested change
| this.sessionLock.lock(); | |
| sessionLock.lock(); |
There is no overloaded field that makes the this. access required, right? Both are correct, but if there is no ambiguity, it's more concise to leave it out.
There was a problem hiding this comment.
Thank you for your valuable feedback.
I actually considered this when making the code changes.
Looking at other classes that use ReentrantLock, I noticed that they all include this.
so I decided to keep it for consistency.
(e.g., SubProtocolWebSocketHandler, InMemoryWebSessionStore.ExpiredSessionChecker)
|
Are you experiencing any actual pinning there? The code within those |
jhoeller
added
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified the part where pinning occurs in DefaultSimpUserRegistry due to the use of synchronized when using VT
I would appreciate any feedback 😃