Propagate CoroutineContext to the CoExchangeFilterFunction
#34555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
added
in: web
sdeleuze
requested changes
Mar 20, 2025
...src/main/kotlin/org/springframework/web/reactive/function/client/CoExchangeFilterFunction.kt
Show resolved
Hide resolved
dmitrysulman
commented
Mar 20, 2025
...webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java
Outdated
Show resolved
Hide resolved
sdeleuze
added
the
status: waiting-for-internal-feedback
sdeleuze
removed
the
status: waiting-for-internal-feedback
pankratz76
approved these changes
Mar 22, 2025
...flux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
Show resolved
Hide resolved
sdeleuze
requested changes
Mar 24, 2025
...flux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
Outdated
Show resolved
Hide resolved
...flux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
Outdated
Show resolved
Hide resolved
...flux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
Outdated
Show resolved
Hide resolved
This commit introduces a new ResponseSpec.awaitEntityOrNull() extension function to replace ResponseSpec.toEntity(...).awaitFirstOrNull() and pass the CoroutineContext to the CoExchangeFilterFunction. CoroutineContext propagation is implemented via ReactorContext and ClientRequest attribute. See spring-projectsgh-32148 Signed-off-by: Dmitry Sulman <dmitry.sulman@gmail.com>
sdeleuze
approved these changes
Mar 26, 2025
|
@sdeleuze Thanks for your feedback and guidance, I really appreciate it. |
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
WebClient.ResponseSpec.awaitEntityOrNull()extension function to replaceWebClient.ResponseSpec.toEntity(...).awaitFirstOrNull()and pass theCoroutineContextfrom the outer scope to theCoExchangeFilterFunction#filtermethod.CoroutineContextpropagation is implemented viaReactorContextandClientRequestattribute.Any feedback is more than welcome.
Fixes #32148