Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename C files to follow current project conventions #6410

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

anandkaranubc
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • renames the C files to follow current project conventions, and also updates the manifest.json accordingly.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 27, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 27, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/ceil 157 / 157
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
157 / 157
+ 100.00 %
math/base/special/ceilf 157 / 157
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
157 / 157
+ 100.00 %
math/base/special/ceiln 272 / 272
+ 100.00 %
24 / 24
+ 100.00 %
2 / 2
+ 100.00 %
272 / 272
+ 100.00 %
math/base/special/clamp 221 / 221
+ 100.00 %
19 / 19
+ 100.00 %
2 / 2
+ 100.00 %
221 / 221
+ 100.00 %
math/base/special/clampf 221 / 221
+ 100.00 %
19 / 19
+ 100.00 %
2 / 2
+ 100.00 %
221 / 221
+ 100.00 %
math/base/special/deg2rad 154 / 154
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
154 / 154
+ 100.00 %
math/base/special/deg2radf 159 / 159
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
159 / 159
+ 100.00 %
math/base/special/floor 157 / 157
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
157 / 157
+ 100.00 %
math/base/special/floorf 157 / 157
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
157 / 157
+ 100.00 %
math/base/special/floorn 272 / 272
+ 100.00 %
24 / 24
+ 100.00 %
2 / 2
+ 100.00 %
272 / 272
+ 100.00 %
math/base/special/inv 168 / 168
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
168 / 168
+ 100.00 %
math/base/special/invf 175 / 175
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
175 / 175
+ 100.00 %
math/base/special/kronecker-delta 183 / 183
+ 100.00 %
10 / 10
+ 100.00 %
2 / 2
+ 100.00 %
183 / 183
+ 100.00 %
math/base/special/kronecker-deltaf 183 / 183
+ 100.00 %
10 / 10
+ 100.00 %
2 / 2
+ 100.00 %
183 / 183
+ 100.00 %
math/base/special/labs 144 / 144
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
144 / 144
+ 100.00 %
math/base/special/pdiff 172 / 172
+ 100.00 %
10 / 10
+ 100.00 %
2 / 2
+ 100.00 %
172 / 172
+ 100.00 %
math/base/special/pdifff 173 / 173
+ 100.00 %
10 / 10
+ 100.00 %
2 / 2
+ 100.00 %
173 / 173
+ 100.00 %
math/base/special/ramp 159 / 159
+ 100.00 %
9 / 9
+ 100.00 %
2 / 2
+ 100.00 %
159 / 159
+ 100.00 %
math/base/special/rampf 159 / 159
+ 100.00 %
9 / 9
+ 100.00 %
2 / 2
+ 100.00 %
159 / 159
+ 100.00 %
math/base/special/rsqrt 186 / 186
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
186 / 186
+ 100.00 %
math/base/special/rsqrtf 176 / 176
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
176 / 176
+ 100.00 %
math/base/special/signum 178 / 178
+ 100.00 %
10 / 10
+ 100.00 %
2 / 2
+ 100.00 %
178 / 178
+ 100.00 %
math/base/special/signumf 178 / 178
+ 100.00 %
9 / 9
+ 100.00 %
2 / 2
+ 100.00 %
178 / 178
+ 100.00 %
math/base/special/sqrt 161 / 161
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
161 / 161
+ 100.00 %
math/base/special/sqrtf 168 / 168
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
168 / 168
+ 100.00 %
math/base/special/truncf 201 / 201
+ 100.00 %
7 / 7
+ 100.00 %
2 / 2
+ 100.00 %
201 / 201
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Contributor Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 28, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 28, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Mar 28, 2025
@kgryte
Copy link
Member

kgryte commented Mar 28, 2025

As the CI failure does not appear to be due to changes in this PR but stems from limitation in our existing tooling (i.e., not using xargs and pipes), I'll go ahead and merge. Thanks for doing this clean-up, @anandkaranubc. This normalization certainly helps with automation.

@kgryte kgryte merged commit 57efa3d into stdlib-js:develop Mar 28, 2025
28 of 29 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 28, 2025
PR-URL: stdlib-js#6410
Reviewed-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
@anandkaranubc
Copy link
Contributor Author

As the CI failure does not appear to be due to changes in this PR but stems from limitation in our existing tooling (i.e., not using xargs and pipes), I'll go ahead and merge.

@kgryte Is this a challenging thing to integrate?

@kgryte
Copy link
Member

kgryte commented Mar 31, 2025

@anandkaranubc No, not necessarily. In short, the problem is with https://github.com/stdlib-js/stdlib/blob/develop/.github/workflows/scripts/run_affected_tests#L170.

Right now, we simply assign the files list to the environment variable FILES. You can see how that is used here: https://github.com/stdlib-js/stdlib/blob/develop/tools/make/lib/test/javascript.mk#L309.

In principle, we should be able to limit the number of files which are assigned to FILES at any one time in the run_affected_tests script by using xargs. Something like

printf "${files}" | xargs -0 -I % make test-javascript-files-min FILES="%"

But that would mean that only 1 file is passed in at a time.

Another way is to refactor the run_affected_tests script to batch the list of files which are passed to the make command. This may be the more straightforward approach.

@anandkaranubc anandkaranubc deleted the rename/c-files branch March 31, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants