Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct variable ordering in cauchy CDF implementation #5542

Closed
wants to merge 3 commits into from
Closed

fix: correct variable ordering in cauchy CDF implementation #5542

wants to merge 3 commits into from

Conversation

ChaitraTM
Copy link

Resolves #5431 .

Description

What is the purpose of this pull request?

This pull request:

  • Fixes the incorrect variable ordering in example.c
  • Removes unnecessary comments
  • Corrects a misnamed variable in benchmark.native.js
  • Updates the Cauchy CDF function description in cdf.h

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 1, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cauchy/cdf $\color{green}287/287$
$\color{green}+100.00\%$ 		$\color{green}19/19$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}287/287$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ChaitraTM ChaitraTM changed the title Fix cauchy cdf fix: correct variable ordering in cauchy CDF implementation Mar 1, 2025
kgryte
kgryte reviewed Mar 1, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md Outdated
@@ -213,9 +213,10 @@ static double random_uniform( const double min, const double max ) {
}

int main( void ) {
//correct order based on the length
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//correct order based on the length

kgryte
kgryte reviewed Mar 1, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js Outdated
@@ -31,10 +31,10 @@ var pkg = require( './../package.json' ).name;


// VARIABLES //

var logcdf = tryRequire( resolve( __dirname, './../lib/native.js' ) );
//corected variable name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//corected variable name

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 1, 2025
@ChaitraTM
Copy link
Author

I ain't getting what's the conflict that must be resolved

@kgryte
Copy link
Member

kgryte commented Mar 2, 2025

@ChaitraTM It looks like you've corrupted this PR. Your most recent commit made hundreds of changes which we do not want. I'll need to close this PR, as the changes won't be accepted as is. I suggest trying again in a separate PR.

@kgryte kgryte closed this Mar 2, 2025
@kgryte kgryte added the Do Not Merge Pull request which should not be merged. label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte

Assignees
No one assigned
Labels
Do Not Merge Pull request which should not be merged. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 8fa3827)
3 participants
@ChaitraTM @stdlib-bot @kgryte