Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix EditorConfig lint errors #6053 #6057

Merged
merged 14 commits into from
Mar 17, 2025

Conversation

Kaushikgtm
Copy link
Contributor

@Kaushikgtm Kaushikgtm commented Mar 15, 2025

Resolves #6053.

Description

What is the purpose of this pull request?

This pull request: Fix EditorConfig lint errors

Related Issues

Resolve EditorConfig lint errors #5156

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Fix EditorConfig lint errors

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 15, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 15, 2025
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 15, 2025

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/bytes-per-element 91 / 91
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
91 / 91
+ 100.00 %
strided/napi/addon-arguments 165 / 165
+ 100.00 %
5 / 5
+ 100.00 %
1 / 1
+ 100.00 %
165 / 165
+ 100.00 %

The above coverage report was generated for the changes in this PR.

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>
@Neerajpathak07
Copy link
Contributor

@Kaushikgtm Pls change the PR tittle to :-
"chore: fix EditorConfig lint errors"

@Kaushikgtm Kaushikgtm changed the title Fix EditorConfig lint errors #6053 chore: fix EditorConfig lint errors #6053 Mar 16, 2025
@Kaushikgtm
Copy link
Contributor Author

@Neerajpathak07 Thanks a lot for your help!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 17, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 17, 2025
@Planeshifter Planeshifter merged commit b6a6575 into stdlib-js:develop Mar 17, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
5 participants