Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/float32/pi-squared #6069

Merged
merged 8 commits into from
Mar 24, 2025
Merged

feat: add constants/float32/pi-squared #6069

merged 8 commits into from
Mar 24, 2025

Conversation

Neerajpathak07
Copy link
Contributor

@Neerajpathak07 Neerajpathak07 commented Mar 15, 2025 •
edited
Loading

Progresses #649
Resolves #6070 .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/pi-squared

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
constants/float32/pi-squared 52 / 52
+ 100.00 % 		1 / 1
+ 100.00 % 		0 / 0
+ 100.00 % 		52 / 52
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review March 15, 2025 11:51
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 15, 2025
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@kgryte kgryte removed the Potential Duplicate There might be another pull request resolving the same issue. label Mar 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft March 16, 2025 09:42
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review March 16, 2025 09:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 16, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 19, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 19, 2025
@Neerajpathak07 Neerajpathak07 requested a review from kgryte March 19, 2025 04:22
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 19, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 19, 2025
@Neerajpathak07
Copy link
Contributor Author

Neerajpathak07 commented Mar 19, 2025 •
edited
Loading

I have made these changes for other PR's as well!! sorry for the confusion from my side.

@Neerajpathak07 Neerajpathak07 mentioned this pull request Mar 24, 2025
Open
1 task
Planeshifter
Planeshifter approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Neerajpathak07!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 24, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Mar 24, 2025
@Planeshifter Planeshifter merged commit a77fb9e into stdlib-js:develop Mar 24, 2025
28 of 29 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
@Neerajpathak07 @sahil20021008
feat: add constants/float32/pi-squared
b533b4e 
PR-URL: stdlib-js#6069
Closes: stdlib-js#6070
Ref: stdlib-js#649

Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte

@Planeshifter Planeshifter

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/pi-squared
4 participants
@Neerajpathak07 @stdlib-bot @Planeshifter @kgryte