Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: resolve lint errors in strided/base/map-by2 #6093

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

gururaj1512
Copy link
Member


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • fix: test cases in strided/base/map-by2

Related Issues

Does this pull request have any related issues?

This pull request:

  • none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 16, 2025

Coverage Report

Package Statements Branches Functions Lines
strided/base/map-by2 608 / 608
+ 100.00 %
42 / 42
+ 100.00 %
6 / 6
+ 100.00 %
608 / 608
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@gururaj1512 gururaj1512 marked this pull request as draft March 17, 2025 07:32
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 17, 2025
Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>
Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>
@gururaj1512 gururaj1512 marked this pull request as ready for review March 17, 2025 07:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 17, 2025
@gururaj1512 gururaj1512 requested a review from kgryte March 17, 2025 07:41
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 17, 2025
@kgryte kgryte changed the title fix: test cases in strided/base/map-by2 style: resolve lint errors in strided/base/map-by2 Mar 17, 2025
@gururaj1512
Copy link
Member Author

@kgryte Got it. I thought it was some kind of style error in stead of lint error

@kgryte kgryte merged commit a0ae68f into stdlib-js:develop Mar 17, 2025
15 checks passed
@gururaj1512 gururaj1512 deleted the fix-map-by2-test branch March 17, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants