Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate math/base/special/cidentity to complex/float64/base/identity #6127

Merged

Conversation

gururaj1512
Copy link
Member

Progresses #2261.

Description

What is the purpose of this pull request?

This pull request:

  • feat!: migrate math/base/special/cidentity to complex/float64/base/identity

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Ref: stdlib-js#2261

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
This commit removes the `cidentity` symbol from the `@stdlib/math/base/special`
namespace due to a package migration.

BREAKING CHANGE: remove `cidentity`

To migrate, users should access the same symbol via the
`@stdlib/complex/float64/base` namespace.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Ref: stdlib-js#2261

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
This commit removes `@stdlib/math/base/special/cidentity` in favor of
`@stdlib/complex/float64/base/identity`.

BREAKING CHANGE: remove `math/base/special/cidentity`

To migrate, users should update their require/import paths to use
`@stdlib/complex/float64/base/identity` which provides the same API and
implementation.

Ref: stdlib-js#2261

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 17, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
complex/float64/base/identity 157 / 157
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
157 / 157
+ 100.00 %
math/base/special 2292 / 2292
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
2292 / 2292
+ 100.00 %
math/base/special/cidentityf 99 / 99
+ 100.00 %
3 / 3
+ 100.00 %
1 / 1
+ 100.00 %
99 / 99
+ 100.00 %
math/base/special 2292 / 2292
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
2292 / 2292
+ 100.00 %
namespace/alias2pkg 95 / 95
+ 100.00 %
7 / 7
+ 100.00 %
1 / 1
+ 100.00 %
95 / 95
+ 100.00 %
namespace 95 / 95
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
95 / 95
+ 100.00 %
namespace/pkg2alias 100 / 100
+ 100.00 %
10 / 10
+ 100.00 %
1 / 1
+ 100.00 %
100 / 100
+ 100.00 %
namespace/pkg2related 100 / 100
+ 100.00 %
10 / 10
+ 100.00 %
1 / 1
+ 100.00 %
100 / 100
+ 100.00 %
namespace/pkg2standalone 95 / 95
+ 100.00 %
7 / 7
+ 100.00 %
1 / 1
+ 100.00 %
95 / 95
+ 100.00 %
namespace/standalone2pkg 95 / 95
+ 100.00 %
7 / 7
+ 100.00 %
1 / 1
+ 100.00 %
95 / 95
+ 100.00 %
strided/base 460 / 460
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
460 / 460
+ 100.00 %
strided/base/map-by 551 / 551
+ 100.00 %
36 / 36
+ 100.00 %
6 / 6
+ 100.00 %
551 / 551
+ 100.00 %
strided/base/mskunary-signature-callbacks 217 / 220
+ 98.64 %
19 / 20
+ 95.00 %
2 / 2
+ 100.00 %
217 / 220
+ 98.64 %
strided/base/unary-by 616 / 616
+ 100.00 %
36 / 36
+ 100.00 %
6 / 6
+ 100.00 %
616 / 616
+ 100.00 %
strided/base/unary-signature-callbacks 217 / 220
+ 98.64 %
19 / 20
+ 95.00 %
2 / 2
+ 100.00 %
217 / 220
+ 98.64 %
strided/base/zmap 250 / 250
+ 100.00 %
9 / 9
+ 100.00 %
2 / 2
+ 100.00 %
250 / 250
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added release: Major Breaking change requiring a new major release. Math Issue or pull request specific to math functionality. and removed Needs Review A pull request which needs code review. labels Mar 18, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 7a67cff into stdlib-js:develop Mar 18, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. release: Major Breaking change requiring a new major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants