Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address commit comments #5431 #6192

Merged
merged 7 commits into from
Mar 20, 2025

Conversation

Eternity0207
Copy link
Contributor

@Eternity0207 Eternity0207 commented Mar 19, 2025

Resolves #5431.

Description

What is the purpose of this pull request?

This pull request:

• Fixes the following issues

8fa3827#r152950715.
Line 174: @stdlib-bot This return value is incorrect. The example should be updated to use similar values as L61 and the return value should be updated accordingly.

8fa3827#r152950726
Line 218: @stdlib-bot Variables should be ordered based on length.

8fa3827#r152950802
Line 31: @stdlib-bot These variables should be ordered by length.

8fa3827#r152950750
Line 35: @stdlib-bot This variable name is incorrect. It should be cdf and updated here and below.

8fa3827#r152950811
Line 30: @stdlib-bot This description is incorrect and should be updated for a Cauchy distribution.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 19, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 19, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cauchy/cdf 287 / 287
+ 100.00 %
19 / 19
+ 100.00 %
4 / 4
+ 100.00 %
287 / 287
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@hrshya
Copy link
Contributor

hrshya commented Mar 19, 2025

You also need to update the PR title to chore: address commit comments .

@Eternity0207 Eternity0207 changed the title Fix: Address commit comments (commit 8fa3827) #5431 Chore: Address commit comments (commit 8fa3827) #5431 Mar 19, 2025
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>
@Eternity0207 Eternity0207 changed the title Chore: Address commit comments (commit 8fa3827) #5431 Chore: Address commit comments #5431 Mar 19, 2025
@Eternity0207
Copy link
Contributor Author

Done @hrshya

@hrshya
Copy link
Contributor

hrshya commented Mar 19, 2025

Change the PR title from Chore: Address commit comments to chore: address commit comments.

@Eternity0207 Eternity0207 changed the title Chore: Address commit comments #5431 chore: address commit comments #5431 Mar 19, 2025
@Eternity0207
Copy link
Contributor Author

done @hrshya

@hrshya
Copy link
Contributor

hrshya commented Mar 19, 2025

Great work! Time to wait for a maintainer to merge this PR :)

@Eternity0207
Copy link
Contributor Author

Thanks for the help

@Eternity0207
Copy link
Contributor Author

@kgryte Please review this PR

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @Eternity0207 for your PR and @hrshya for review!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 20, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 20, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 20, 2025

PR Commit Message

chore: address commit comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/6192
Closes: https://github.com/stdlib-js/stdlib/issues/5431

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Harsh <149176984+hrshya@users.noreply.github.com>
Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 30f9a5f into stdlib-js:develop Mar 20, 2025
35 of 37 checks passed
@Planeshifter Planeshifter mentioned this pull request Mar 20, 2025
1 task
@Eternity0207 Eternity0207 deleted the patch-6 branch March 20, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 8fa3827)
4 participants