Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/eulergamma #6209

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Neerajpathak07
Copy link
Contributor

Progresses #649.

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/eulergamma

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 19, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/eulergamma 53 / 53
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
53 / 53
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review March 19, 2025 19:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 19, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 19, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 19, 2025
@Neerajpathak07
Copy link
Contributor Author

@kgryte At this point my Vs Code is just autocorrecting the var name to the existing package that we have for float32. But I have made the changes and disabled the feature locally.

@Neerajpathak07 Neerajpathak07 requested a review from kgryte March 20, 2025 03:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 20, 2025
@Neerajpathak07
Copy link
Contributor Author

The double-precision version uses GAMMA wouldn't it be desired to change to EULERGAMMA

@kgryte
Copy link
Member

kgryte commented Mar 20, 2025

The double-precision version uses GAMMA wouldn't it be desired to change to EULERGAMMA

Feel free to open a PR updating constants/float64/eulergamma to enforce consistency with EULERGAMMA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants