Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use consistent naming in constants/float64/eulergamma #6228

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

Krishna-Sharma-g
Copy link
Contributor

Resolves #6222 .

Description

What is the purpose of this pull request?

This pull request:

  • updated the gamma to eulergamma in the package

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 20, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
constants/float64/eulergamma 49 / 49
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
49 / 49
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@Krishna-Sharma-g Krishna-Sharma-g changed the title update : constants/float64/eulergamma to enforce consistency with EULERGAMMA. fix : constants/float64/eulergamma to enforce consistency with EULERGAMMA. Mar 20, 2025
@Neerajpathak07
Copy link
Contributor

@Krishna-Sharma-g Pls change the PR tittle to :-
" chore:- update constants/float64/eulergamma to enforce consistency with EULERGAMMA

@Krishna-Sharma-g
Copy link
Contributor Author

@Neerajpathak07 please review is this what you wanted us to do in this issue or i have to do something else

@Neerajpathak07
Copy link
Contributor

Other than that everything LGTM!!

@Krishna-Sharma-g Krishna-Sharma-g changed the title fix : constants/float64/eulergamma to enforce consistency with EULERGAMMA. chore:- update constants/float64/eulergamma to enforce consistency with EULERGAMMA Mar 20, 2025
@Krishna-Sharma-g
Copy link
Contributor Author

okay thanks !! @Neerajpathak07

@Neerajpathak07
Copy link
Contributor

@Krishna-Sharma-g don't forget to add backticks before and the package name my friend.

@Krishna-Sharma-g Krishna-Sharma-g changed the title chore:- update constants/float64/eulergamma to enforce consistency with EULERGAMMA chore:- update constants/float64/eulergamma to enforce consistency with EULERGAMMA Mar 20, 2025
@Neerajpathak07
Copy link
Contributor

No need to worry try this:-
"chore: update constants/float64/eulergamma for usage of variable EULERGAMMA "

@Krishna-Sharma-g Krishna-Sharma-g changed the title chore:- update constants/float64/eulergamma to enforce consistency with EULERGAMMA chore: update constants/float64/eulergamma for usage of variable EULERGAMMA " Mar 20, 2025
@Krishna-Sharma-g
Copy link
Contributor Author

No need to worry try this:- "chore: update constants/float64/eulergamma for usage of variable EULERGAMMA "

okay thanks !!

@Neerajpathak07
Copy link
Contributor

cc:- @kgryte

@kgryte kgryte changed the title chore: update constants/float64/eulergamma for usage of variable EULERGAMMA " chore: using consistent naming in constants/float64/eulergamma Mar 21, 2025
@kgryte kgryte changed the title chore: using consistent naming in constants/float64/eulergamma chore: use consistent naming in constants/float64/eulergamma Mar 21, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 21, 2025
@kgryte kgryte merged commit f4bf6e6 into stdlib-js:develop Mar 21, 2025
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: update constants/float64/eulergamma to enforce consistency with EULERGAMMA
4 participants