Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: update random value generation #6301

Merged
merged 2 commits into from
Mar 22, 2025
Merged

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 22, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the math/base/special/copysign, math/base/special/cosm1, math/base/special/cospi and math/base/special/cosh packages.
  • Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/copysign 207 / 207
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
207 / 207
+ 100.00 %
math/base/special/copysignf 203 / 203
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
203 / 203
+ 100.00 %
math/base/special/cosm1 242 / 242
+ 100.00 %
12 / 12
+ 100.00 %
3 / 3
+ 100.00 %
242 / 242
+ 100.00 %
math/base/special/cospi 217 / 217
+ 100.00 %
20 / 20
+ 100.00 %
2 / 2
+ 100.00 %
217 / 217
+ 100.00 %

The above coverage report was generated for the changes in this PR.

anandkaranubc
anandkaranubc previously approved these changes Mar 22, 2025
@anandkaranubc
Copy link
Contributor

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 22, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 22, 2025
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Thanks @hrshya

@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. labels Mar 22, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit b103cae into stdlib-js:develop Mar 22, 2025
29 checks passed
Girish-Garg pushed a commit to Girish-Garg/stdlib that referenced this pull request Mar 23, 2025
PR-URL: stdlib-js#6301
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants