-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: update random value generation #6301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
The above coverage report was generated for the changes in this PR. |
anandkaranubc
previously approved these changes
Mar 22, 2025
/stdlib lint-autofix |
anandkaranubc
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Thanks @hrshya
kgryte
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Girish-Garg
pushed a commit
to Girish-Garg/stdlib
that referenced
this pull request
Mar 23, 2025
PR-URL: stdlib-js#6301 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Co-authored-by: stdlib-bot <noreply@stdlib.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Benchmarks
Pull requests adding or improving benchmarks for measuring performance.
Math
Issue or pull request specific to math functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves none .
Description
This pull request:
math/base/special/copysign
,math/base/special/cosm1
,math/base/special/cospi
andmath/base/special/cosh
packages.randu()
withuniform()
from@stdlib/random/array/uniform
for cleaner and more consistent code.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers