Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate stats/base/dnanmin to stats/strided/dnanmin #6307

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

aayush0325
Copy link
Member

Towards #4797.

Description

What is the purpose of this pull request?

This pull request:

  • take 2 at trying to automate the process of migrating packages

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Ref: stdlib-js#4797

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
This commit removes the `dnanmin` symbol from the `@stdlib/stats/base` namespace due to a package migration.

BREAKING CHANGE: remove `stats/base/dnanmin`

To migrate, users should access the same symbol via the `@stdlib/stats/strided/dnanmin` namespace.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Ref: stdlib-js#4797

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
This commit removes `@stdlib/stats/base/dnanmin` in favor of `@stdlib/stats/strided/dnanmin`.

BREAKING CHANGE: remove `stats/base/dnanmin`

To migrate, users should update their require/import paths to use
`@stdlib/stats/strided/dnanmin`, which provides the same API and implementation.

Ref: stdlib-js#4797

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 22, 2025
@@ -48,7 +48,7 @@ var v = nanminBy( x.length, x, 1, accessor );
The function has the following parameters:

- **N**: number of indexed elements.
- **x**: input [`Array`][mdn-array], [`typed array`][mdn-typed-array], or an array-like object (excluding strings and functions).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script pauses and waits for me to resolve any errors in my editor if it encounters any linting issues

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
namespace 95 / 95
+ 100.00 %
4 / 4
+ 100.00 %
1 / 1
+ 100.00 %
95 / 95
+ 100.00 %
stats/base 1905 / 1905
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
1905 / 1905
+ 100.00 %
stats/base/dmskmin 411 / 411
+ 100.00 %
31 / 31
+ 100.00 %
4 / 4
+ 100.00 %
411 / 411
+ 100.00 %
stats/base/dnanminabs 381 / 381
+ 100.00 %
29 / 29
+ 100.00 %
4 / 4
+ 100.00 %
381 / 381
+ 100.00 %
stats/base/dnanmskmin 470 / 470
+ 100.00 %
57 / 57
+ 100.00 %
4 / 4
+ 100.00 %
470 / 470
+ 100.00 %
stats/base/dnanrange 386 / 386
+ 100.00 %
33 / 33
+ 100.00 %
4 / 4
+ 100.00 %
386 / 386
+ 100.00 %
stats/base 1905 / 1905
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
1905 / 1905
+ 100.00 %
stats/base/nanmin-by 286 / 286
+ 100.00 %
51 / 51
+ 100.00 %
2 / 2
+ 100.00 %
286 / 286
+ 100.00 %
stats/base/nanmin 267 / 267
+ 100.00 %
45 / 45
+ 100.00 %
2 / 2
+ 100.00 %
267 / 267
+ 100.00 %
stats/base/snanmin 380 / 380
+ 100.00 %
31 / 31
+ 100.00 %
4 / 4
+ 100.00 %
380 / 380
+ 100.00 %
stats/strided/dmin 369 / 369
+ 100.00 %
25 / 25
+ 100.00 %
4 / 4
+ 100.00 %
369 / 369
+ 100.00 %
stats/strided/dnanmax 380 / 380
+ 100.00 %
31 / 31
+ 100.00 %
4 / 4
+ 100.00 %
380 / 380
+ 100.00 %
stats/strided/dnanmin 381 / 381
+ 100.00 %
31 / 31
+ 100.00 %
4 / 4
+ 100.00 %
381 / 381
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added release: Major Breaking change requiring a new major release. and removed Needs Review A pull request which needs code review. labels Mar 26, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 343bd74 into stdlib-js:develop Mar 26, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: Major Breaking change requiring a new major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants