Pin SQLAlchemy verison #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the requirements.txt did not pin a SQLAlchemy version. Newer versions of SQLAlchemy removed the relation function used in the videos: https://github.com/sqlalchemy/sqlalchemy/blob/d519bca7f953a0520cda79504dbc019e74e87b28/lib/sqlalchemy/orm/__init__.py#L143 The demo code uses relation instead of the newer relationship code, so in order for the demo to work, users must install an older version of SQLAlchemy. The videos used SQLAlchemy 1.2.10. This version is old enough that it is incompatible with with Python 3.10. Trying to execute the demo code yields the following error: > AttributeError: module 'collections' has no attribute 'MutableMapping' I found that version 1.2.19 was new enough to work with modern Python while still maintaining the relation function. This commit pins 1.2.19 in the requirements.txt file so other students do not run into the same issue.
|
Thanks @dhenschen for trying different versions and pinning the one that worked for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the requirements.txt did not pin a SQLAlchemy version.
Newer versions of SQLAlchemy removed the
relationfunction used in the videos: https://github.com/sqlalchemy/sqlalchemy/blob/d519bca7f953a0520cda79504dbc019e74e87b28/lib/sqlalchemy/orm/__init__.py#L143The demo code uses
relationinstead of the newerrelationshipfunction, so in order for the demo to work, users must install an older version of SQLAlchemy.The videos used SQLAlchemy 1.2.10. This version is old enough that it is incompatible with with Python 3.10. Trying to execute the demo code yields the following error:
I found that version 1.2.19 was new enough to work with modern Python while still maintaining the
relationfunction. This Pull Request pins 1.2.19 in the requirements.txt file so other students do not run into the same issue.