Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary #10894

Open
4 tasks done
kirkwaiblinger opened this issue Feb 27, 2025 · 0 comments · May be fixed by #10907
Open
4 tasks done
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Feb 27, 2025

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

(BRANCH PLAYGROUND - NOT ON MAIN YET)

Repro Code

function join<T extends string | number>(els: T[]) {
  return els.map(el => '' + el).join(',');
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-unnecessary-type-parameters": "warn"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

function join(els: (string | number)[]) {
  return els.map(el => '' + el).join(',');
}

Actual Result

function join(els: string | number[]) {
  return els.map(el => '' + el).join(',');
}

Additional Info

This is a followup to #9536 (comment). note that, while this specific report case isn't merged yet,

  • I'm pretty sure it will be merged imminently
  • I'm pretty sure we could figure out a repro where the parenthesization is wrong on a case the rule already reports on, but I haven't bothered thinking too hard about it
@kirkwaiblinger kirkwaiblinger added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 27, 2025
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
2 participants