Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Integration test failure on main: flat-config-types-@types__eslint-v8 & -v9 #10992

Open
JoshuaKGoldberg opened this issue Mar 24, 2025 · 0 comments · May be fixed by #11002
Open

Repo: Integration test failure on main: flat-config-types-@types__eslint-v8 & -v9 #10992

JoshuaKGoldberg opened this issue Mar 24, 2025 · 0 comments · May be fixed by #11002
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 24, 2025

Suggestion

Example from https://github.com/typescript-eslint/typescript-eslint/actions/runs/14020474109/job/39251785162?pr=10861:

FAIL  tests/flat-config-types-@types__eslint-v9.test.ts (54.762 s)
  ● flat-config-types-@types__eslint-v9 › typescript › should work successfully
    expect(received).toHaveLength(expected)
    Expected length: 0
    Received length: 5
    Received array:  ["eslint.config.js(55,19): error TS23[45](https://github.com/typescript-eslint/typescript-eslint/actions/runs/14020474109/job/39251785162?pr=10861#step:5:59): Argument of type '{ plugins: string[]; rules: { 'deprecation/deprecation': string; }; }' is not assignable to parameter of type 'LegacyConfig<RulesRecord, RulesRecord>'.", "  Types of property 'rules' are incompatible.", "    Type '{ 'deprecation/deprecation': string; }' is not assignable to type 'Partial<RulesRecord>'.", "      Property ''deprecation/deprecation'' is incompatible with index signature.", "        Type 'string' is not assignable to type 'RuleEntry<any[]>'."]

      23 |
      24 |       // The types should not error (e.g. https://github.com/eslint-stylistic/eslint-stylistic/issues/276)
    > 25 |       expect(lines).toHaveLength(0);
         |                     ^
      26 |     },
      27 |   );
      28 | }

      at toHaveLength (tests/flat-config-types-@types__eslint-v9.test.ts:25:21)
      at assertOutput (tools/integration-test-base.ts:197:7)
      at Object.<anonymous> (tools/integration-test-base.ts:120:9)
eslint.config.js(55,19): error TS2345: Argument of type '{ plugins: string[]; rules: { 'deprecation/deprecation': string; }; }' is not assignable to parameter of type 'LegacyConfig<RulesRecord, RulesRecord>'.
  Types of property 'rules' are incompatible.
    Type '{ 'deprecation/deprecation': string; }' is not assignable to type 'Partial<RulesRecord>'.
      Property ''deprecation/deprecation'' is incompatible with index signature.
        Type 'string' is not assignable to type 'RuleEntry<any[]>'."]

Additional Info

A few related issues & PRs:

Related "we should automate something here" integration test tracker: #8603

💖

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs labels Mar 24, 2025
@JoshuaKGoldberg JoshuaKGoldberg pinned this issue Mar 27, 2025
KuSh added a commit to KuSh/typescript-eslint that referenced this issue Mar 27, 2025
@KuSh KuSh linked a pull request Mar 27, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant