Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): Show tsconfig parsing errors in tab #10991

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

WIP.
I'm trying to manage tsconfig errors with different markers and statuses.

Because I couldn't integrate tsconfig errors into markers since markers change depending on editor changes, and I thought it was wrong to apply tsconfig where markers are created.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@developer-bandi developer-bandi marked this pull request as draft March 23, 2025 15:00
Copy link

netlify bot commented Mar 23, 2025

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 5c65c43
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67e02211bfbccd0008775a22

Copy link

nx-cloud bot commented Mar 23, 2025

View your CI Pipeline Execution ↗ for commit 5c65c43.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 3s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-23 15:01:31 UTC

@armano2
Copy link
Collaborator

armano2 commented Mar 23, 2025

maybe we should just extends fs to contain info about errors for specific files, with that we could change/swap what we display based on file that is selected?

tsconfig is a file (model) in monaco, similar to any other file, and its cloned as vfs file

@developer-bandi
Copy link
Contributor Author

developer-bandi commented Mar 24, 2025

maybe we should just extends fs to contain info about errors for specific files, with that we could change/swap what we display based on file that is selected?

tsconfig is a file (model) in monaco, similar to any other file, and its cloned as vfs file

If I understand correctly, you mean changing the type of markers to Record<TabType,ErrorGroup[]> and displaying the corresponding error depending on the selected tab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Display tsconfig errors in playground
2 participants