Generalize split.py and keep inline namespaces #2041
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make split.py usable on other httplib files.
Overrides the default list of libraries to split.
Overrides the directory to look for libraries.
falbrechtskirchinger
force-pushed
the
split
branch
from
7275d3e to
d8b2894
Compare
yhirose
force-pushed
the
master
branch
3 times, most recently
from
80a40ce to
39a64fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize
split.pyto split future httplib files. Files are now searched in a selectable base directory (defaults to script directory) and relative search directories.inline namespaces will be kept.This is intended to be able to split the upcoming WebSockets implementation in
httplib-ws.h.