Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZP-12866] Use FakeR instead of R.java #11

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

zenput-paul
Copy link

I still need to test it

Copy link

@davidofwatkins davidofwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Glad it was a relatively easy fix!

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@zenput/cordova-plugin-image-picker",
"version": "22.10.20-H17M24S13",
"version": "23.8.30-H08M20S22",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike Zencam, I don't think we have CI set up to deploy this automatically on merge to main. So, I think you'll have to manually run this from your local:

npm run calversion
npm publish

I would do that from this PR just before you merge to main instead of after, since it will make a diff in the code that needs to be committed. (This is from memory, so I may be slightly off. We should really document the publishing process in the README.)

@zenput-paul zenput-paul merged commit d5faa07 into main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants