Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distclean should remove what make clean removes and configure artifacts #2977

Closed
wants to merge 1 commit into from

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Mar 25, 2025

See: https://www.gnu.org/software/automake/manual/automake.html#Clean

Currently we would leave the tex output after a make dist which does get removed after make clean so make distclean was not a superset of make clean. Easiest way of achieving that is a recursive target on top. We remove nothing in that folder so I'm not sure if we want to set it lower in the subdirectories (what is the convention?).

@vmcj vmcj requested a review from eldering March 25, 2025 07:11
Copy link
Member

@eldering eldering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already https://github.com/DOMjudge/domjudge/blob/main/Makefile.global#L90, so I think the correct way to do this is add a clean-l target and let clean depend on that. That keeps the whole setup consistent.

@vmcj
Copy link
Member Author

vmcj commented Mar 25, 2025

There's already https://github.com/DOMjudge/domjudge/blob/main/Makefile.global#L90, so I think the correct way to do this is add a clean-l target and let clean depend on that. That keeps the whole setup consistent.

So replace in every Makefile, the target clean with clean-l?

@vmcj
Copy link
Member Author

vmcj commented Mar 25, 2025

Digging a bit further it seems that we do this correctly for most (or all) directories. For the doc/manual/build we leave too many files. I think we should clean those with a make clean, what are your thoughts @eldering?

@eldering
Copy link
Member

Digging a bit further it seems that we do this correctly for most (or all) directories. For the doc/manual/build we leave too many files. I think we should clean those with a make clean, what are your thoughts @eldering?

Yeah, probably call the clean targets in the sphinx generated makefiles from doc/manual/Makefile. There's actually already some of that there.

@vmcj vmcj closed this Mar 26, 2025
@vmcj vmcj deleted the make_clean_distclean branch March 26, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants