Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish.steps.type is always null #17

Closed
wolfflow opened this issue Oct 20, 2020 · 0 comments · Fixed by #18
Closed

publish.steps.type is always null #17

wolfflow opened this issue Oct 20, 2020 · 0 comments · Fixed by #18

Comments

@wolfflow
Copy link

wolfflow commented Oct 20, 2020 •
edited
Loading

What

Fix documentation typo
Post-publish check for publish.steps.type != 'none' always fails as it is not being an updated part of publish step and always equals to null (see action debug output below)

##[debug]Evaluating: (success() && (steps.publish.outputs.type != 'none'))
......
......
##[debug]..Evaluating NotEqual:
##[debug]....Evaluating Index:
##[debug]......Evaluating Index:
##[debug]........Evaluating steps:
##[debug]........=> Object
##[debug]........Evaluating String:
##[debug]........=> 'publish'
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'type'
##[debug]....=> null
##[debug]....Evaluating Null:
##[debug]....=> null
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (true && (null != 'none'))

How

Update documentation: mention that one should use publish.steps.outputs.type instead of publish.steps.type.

Action debug output is below (how it works with steps.publish.outputs.type set properly):

##[debug]Evaluating: (success() && (steps.publish.outputs.type != 'none'))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating NotEqual:
##[debug]....Evaluating Index:
##[debug]......Evaluating Index:
##[debug]........Evaluating Index:
##[debug]..........Evaluating steps:
##[debug]..........=> Object
##[debug]..........Evaluating String:
##[debug]..........=> 'publish'
##[debug]........=> Object
##[debug]........Evaluating String:
##[debug]........=> 'outputs'
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'type'
##[debug]....=> 'patch'
##[debug]....Evaluating String:
##[debug]....=> 'none'
##[debug]..=> true
##[debug]=> true
##[debug]Expanded: (true && ('patch' != 'none'))
##[debug]Result: true

Result

Documentation is updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation for Output Variables - steps.publish.outputs.type wolfflow/npm-publish
1 participant
@wolfflow