fixup: fix suppressed error bug

src/compare-and-publish/__tests__/compare-and-publish.test.ts

@@ -222,4 +222,34 @@ describe("compareAndPublish", () => {
       type: "major",
     });
   });
+
+  it("should raise if the retried npm view call fails", async () => {
+    td.when(getViewArguments("fizzbuzz", normalizedOptions, true)).thenReturn([
+      "fizzbuzz@cool-tag",
+    ]);
+
+    td.when(
+      callNpmCli("view", ["fizzbuzz"], { logger, environment })
+    ).thenResolve({
+      successData: undefined,
+      errorCode: undefined,
+      error: undefined,
+    });
+
+    td.when(
+      callNpmCli("view", ["fizzbuzz@cool-tag"], { logger, environment })
+    ).thenResolve({
+      successData: undefined,
+      errorCode: "E500",
+      error: new errors.NpmCallError("view", 1, "oh no"),
+    });
+
+    const result = subject.compareAndPublish(
+      manifest,
+      normalizedOptions,
+      environment
+    );
+
+    await expect(result).rejects.toThrow(errors.NpmCallError);
+  });
 });

src/compare-and-publish/compare-and-publish.ts

@@ -41,10 +41,6 @@ export async function compareAndPublish(
   const publishArguments = getPublishArguments(packageSpec, options);
   let viewCall = await callNpmCli(VIEW, viewArguments, cliOptions);
 
-  if (viewCall.error && viewCall.errorCode !== E404) {
-    throw viewCall.error;
-  }
-
   // `npm view` will succeed with no output the package exists in the registry
   // with no `latest` tag. This is only possible with third-party registries.
   // https://github.com/npm/cli/issues/6408
@@ -55,6 +51,10 @@ export async function compareAndPublish(
     viewCall = await callNpmCli(VIEW, viewWithTagArguments, cliOptions);
   }
 
+  if (viewCall.error && viewCall.errorCode !== E404) {
+    throw viewCall.error;
+  }
+
   const comparison = compareVersions(version, viewCall.successData, options);
   const publishCall = comparison.type
     ? await callNpmCli(PUBLISH, publishArguments, cliOptions)