Skip to content

Commit ef5a814

Browse files
committedAug 11, 2024
Fix bug
1 parent 58769a0 commit ef5a814

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed
 

‎node/lib/retire.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,11 @@ exports.scanUri = function (uri, repo) {
167167
return check(result, repo);
168168
};
169169

170-
exports.scanFileName = function (fileName, repo) {
170+
exports.scanFileName = function (fileName, repo, includeUri = false) {
171171
var result = scan(fileName, 'filename', repo, splitAndMatchAll(/[\/\\]/));
172+
if (includeUri) {
173+
result = result.concat(scan(fileName.replace(/\\/g, '/'), 'uri', repo));
174+
}
172175
return check(result, repo);
173176
};
174177

‎node/spec/tests/filenamescan.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,12 @@ describe('filename scan', function () {
5757
done();
5858
});
5959
it('should_be_vulnerable_when_path_matches_uri_linux', function (done) {
60-
var result = retire.scanFileName('/usr/file/1.8.1/jquery.js', repo);
60+
var result = retire.scanFileName('/usr/file/1.8.1/jquery.js', repo, true);
6161
assert.isVulnerable(result);
6262
done();
6363
});
6464
it('should_be_vulnerable_when_path_matches_uri_win', function (done) {
65-
var result = retire.scanFileName('\\usr\\file\\1.8.1\\jquery.js', repo);
65+
var result = retire.scanFileName('\\usr\\file\\1.8.1\\jquery.js', repo, true);
6666
assert.isVulnerable(result);
6767
done();
6868
});

‎node/src/retire.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export declare function isVulnerable(results: Component[]): boolean;
88

99
export declare function scanUri(uri: string, repo: Repository): Component[];
1010

11-
export declare function scanFileName(fileName: string, repo: Repository): Component[];
11+
export declare function scanFileName(fileName: string, repo: Repository, includeUri: boolean): Component[];
1212

1313
export declare function scanFileContent(content: string, repo: Repository, hasher: Hasher): Component[];
1414

‎node/src/scanner.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,7 @@ export function scanJsFile(file: string, repo: Repository, options: Options) {
111111
if (options.ignore && shouldIgnorePath([file], options.ignore)) {
112112
return;
113113
}
114-
let results = retire.scanUri(file, repo);
115-
if (!results || results.length === 0) {
116-
results = retire.scanFileName(file, repo);
117-
}
114+
let results = retire.scanFileName(file, repo, true);
118115
if (!results || results.length === 0) {
119116
const content = fs.readFileSync(file, 'utf-8');
120117
results = retire.scanFileContent(content, repo, hash);

0 commit comments

Comments
 (0)
Failed to load comments.