-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating version_check function #180
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 7ed8c7f into 88bf768 - view on LGTM.com new alerts:
|
Hi. Could u fix problem with error in build? |
I can't really see what the issue is @Arfey it seems to be failing on library click, but click is already in the requirements and is imported as part of the travis build. |
I see 2 error with bandit
Error with
as solution u can try move import into if u'll not find solution text me and we'll try solve together |
Removing unneeded import
This pull request introduces 1 alert when merging c4fb7b6 into 34b1e70 - view on LGTM.com new alerts:
|
Update urllib request to remove open and replace with Request
Fixing indentation
This pull request introduces 2 alerts when merging b0a758f into 34b1e70 - view on LGTM.com new alerts:
|
Fixing try except pass bandit issue
This pull request introduces 1 alert when merging 3cbd444 into 34b1e70 - view on LGTM.com new alerts:
|
Update versiontools.py Removing unneeded import Update versiontools.py Update urllib request to remove open and replace with Request Update versiontools.py Fixing indentation Update versiontools.py Fixing try except pass bandit issue
I've refactored it to not use the import @Arfey but it still throws an error on the click import. Bandit is still throwing some warnings, but I expect them all. |
This pull request introduces 3 alerts when merging 5bad186 into 34b1e70 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1b8ec66 into 34b1e70 - view on LGTM.com new alerts:
|
|
What do these changes do?
These changes check that the create-aio-app is the latest version, PR requested by @Arfey #104 (comment)