Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): correct handling of response/request errors #29903

Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix(@angular/build): correct handling of response/request errors #29903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/build/src/utils/server-rendering/launch-server.ts
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ export async function launchServer(): Promise<URL> {
// handle request
if (isSsrNodeRequestHandler(reqHandler)) {
await reqHandler(req, res, (e) => {
throw e;
throw e ?? new Error(`Unable to handle request: '${req.url}'.`);
});
} else {
const webRes = await reqHandler(createWebRequestFromNodeRequest(req));
6 changes: 3 additions & 3 deletions packages/angular/build/src/utils/server-rendering/prerender.ts
View file
Original file line number Diff line number Diff line change
@@ -113,7 +113,7 @@ export async function prerenderPages(
outputMode,
).catch((err) => {
return {
errors: [`An error occurred while extracting routes.\n\n${err.stack ?? err.message ?? err}`],
errors: [`An error occurred while extracting routes.\n\n${err.message ?? err.stack ?? err}`],
serializedRouteTree: [],
appShellRoute: undefined,
};
@@ -258,7 +258,7 @@ async function renderPages(
})
.catch((err) => {
errors.push(
`An error occurred while prerendering route '${route}'.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
`An error occurred while prerendering route '${route}'.\n\n${err.message ?? err.stack ?? err.code ?? err}`,
);
void renderWorker.destroy();
});
@@ -359,7 +359,7 @@ async function getAllRoutes(

return {
errors: [
`An error occurred while extracting routes.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
`An error occurred while extracting routes.\n\n${err.message ?? err.stack ?? err.code ?? err}`,
],
serializedRouteTree: [],
};