Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): remove explicit outputPath option value from generated applications #29905

Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(@schematics/angular): remove explicit outputPath option value from generated applications #29905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/schematics/angular/application/index.ts
View file
Original file line number Diff line number Diff line change
@@ -236,7 +236,6 @@ function addAppToWorkspaceFile(
builder: Builders.BuildApplication,
defaultConfiguration: 'production',
options: {
outputPath: `dist/${folderName}`,
index: `${sourceRoot}/index.html`,
browser: `${sourceRoot}/main.ts`,
polyfills: options.experimentalZoneless ? [] : ['zone.js'],
9 changes: 3 additions & 6 deletions packages/schematics/angular/ssr/index.ts
View file
Original file line number Diff line number Diff line change
@@ -81,12 +81,9 @@ async function getApplicationBuilderOutputPaths(
throw new SchematicsException(`Cannot find 'options' for ${projectName} ${target} target.`);
}

const { outputPath } = architectTarget.options;
if (outputPath === null || outputPath === undefined) {
throw new SchematicsException(
`outputPath for ${projectName} ${target} target is undefined or null.`,
);
}
let { outputPath } = architectTarget.options;
// Use default if not explicitly specified
outputPath ??= posix.join('dist', projectName);

const defaultDirs = {
server: DEFAULT_SERVER_DIR,
4 changes: 2 additions & 2 deletions packages/schematics/angular/ssr/index_spec.ts
View file
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ describe('SSR Schematic', () => {
const build = config.projects['test-app'].architect.build;

build.options.outputPath = {
base: build.options.outputPath,
base: 'dist/test-app',
browser: 'public',
server: 'node-server',
};
@@ -139,7 +139,7 @@ describe('SSR Schematic', () => {
const build = config.projects['test-app'].architect.build;

build.options.outputPath = {
base: build.options.outputPath,
base: 'dist/test-app',
browser: '',
server: 'node-server',
};
1 change: 1 addition & 0 deletions tests/legacy-cli/e2e/tests/build/jit-ngmodule.ts
View file
Original file line number Diff line number Diff line change
@@ -23,6 +23,7 @@ export default async function () {
main: build.options.browser,
browser: undefined,
buildOptimizer: false,
outputPath: 'dist/test-project-two',
};

build.configurations.development = {
1 change: 1 addition & 0 deletions tests/legacy-cli/e2e/tests/build/rebuild-dot-dirname.ts
View file
Original file line number Diff line number Diff line change
@@ -33,6 +33,7 @@ export default async function () {
...build.options,
main: build.options.browser,
browser: undefined,
outputPath: 'dist/subdirectory-test-project',
};

build.configurations.development = {
1 change: 1 addition & 0 deletions tests/legacy-cli/e2e/tests/build/relative-sourcemap.ts
View file
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ export default async function () {
...build.options,
main: build.options.browser,
browser: undefined,
outputPath: 'dist/secondary-project',
};

build.configurations.development = {