Patch port of initial rules_js migration PR
#30654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
rjs-1-patch
branch
2 times, most recently
from
a432375 to
a2349fd
Compare
This is necessary for an incremental migration to `rules_js` which requires Bazel v6. Bazel v6 removed the managed directories feature, which means we no longer can rely on symlinked node modules as the Bazel repository; but rather need to duplicate dependencies. This is okay/acceptable to enable the incremental migration.
Sets up `rules_js` and links dependencies into the bazel-bin.
This commit sets up `rules_ts`, providing the `ts_library` equivalent for the `rules_js` migration.
The `ts_project` interop rule that we've built was also used in the Angular CLI migration, and it allows us to mix `ts_project` and `ts_library` targets; enabling an incremental migration.
This is an initial commit to migrate some `testing/` targets to `ts_project`, leveraging the interop rule we've built. Notably we also turn of strict deps checking temporarily as the deps checking is only applicable when there are no interop deps anymore!
devversion
added
target: patch
devversion
requested review from
a team,
andrewseguin and
jelbourn
as code owners
andrewseguin
approved these changes
Mar 19, 2025
* Moves the public API goldens to `goldens/` * Switches us to the `npm_package` variant of the golden testing rule. This variant is more future proof and will work well with the `rules_js` migration (as it takes arbitrary Bazel tree artifacts)
This will automatically result in Renovate updating the Aspect lock files.
This will result in the release tool automatically updating the Aspect lock files when necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch port of #30629